Date: Sun, 16 Jul 2000 01:22:09 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Paul Saab <paul@mu.org> Cc: Warner Losh <imp@village.org>, Paul Saab <ps@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c Message-ID: <Pine.BSF.4.21.0007160040120.3361-100000@besplex.bde.org> In-Reply-To: <20000714122507.A10475@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 Jul 2000, Paul Saab wrote: > Warner Losh (imp@village.org) wrote: > > In message <200007141149.EAA96783@freefall.freebsd.org> Paul Saab writes: > > : This will solve the problem with having DDB enabled and getting an > > : NMI due to some possibly bad error and being able to continue the > > : operation of the kernel when you really want to panic and know > > : what happened. > > > > Does this work on all motherboards? Steve Passe wrote similar code a > > long time ago, which i dusted off and tried to submit. Both Steve and > > bde were worried that it was too motherboard and/or chipset dependent. As Steve mentioned, his code was for a different problem. However, the NMI decoding code may be too machine-dependent to rely on. I think isa_nmi() should be changed to just print a message and return status (or to return a string giving the message). Then the caller can panic as required (never panic immediately if DDB is configured). Note that the panic after the first isa_nmi() in trap.c is bogus. isa_nmi() never returns nonzero. It panics instead. The FALLTHROUGH after the second isa_nmi() trap.c is bogus for the same reason. trap_fatal() would print more information about the context, but is never reached. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0007160040120.3361-100000>