From owner-freebsd-bluetooth@FreeBSD.ORG Tue Mar 18 16:24:19 2008 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 614FB106564A for ; Tue, 18 Mar 2008 16:24:19 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id F312E8FC1F for ; Tue, 18 Mar 2008 16:24:18 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so5232942fgg.35 for ; Tue, 18 Mar 2008 09:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=qf8LRrvZrTxpVghw4C+4juRics9eQFUfPEwRSc5hQIk=; b=MeG9uMdmHBIu3cB/cUfjl2cfbXqRnAToeFVNOyoN+nKOcobS0BmUTosnV6BmxhJGDK51Tz2sPjIurJrC1DRLV81dRb1t+bVQFGXYfsyveNtxvgcIEMCnRgEaneUUi+vqyhguW/UTXN6zwmUv1QAo9o5vR+fzUG6HIsUhr7JNQkM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qeo1WVc8Idr3coNqHbfgOj6oI9yTHkXTwobSwFzWNEhCtGFmOvVL3fM0AToNHgdaoU462AVPRVo1xcUFWahnvTRWsA+87Z5lmVLkFF4ioE4qNFerOE/v/bYgk8Sp6WGe+8Gp/XKR7q8mn2CsQvsV+qrfICmSy0+T3IVm1vahxlg= Received: by 10.82.121.15 with SMTP id t15mr3036392buc.8.1205857456090; Tue, 18 Mar 2008 09:24:16 -0700 (PDT) Received: by 10.86.23.12 with HTTP; Tue, 18 Mar 2008 09:24:16 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2008 08:24:16 -0800 From: "Maksim Yevmenkin" To: "Iain Hibbert" In-Reply-To: <1205833527.826584.1207.nullmailer@galant.ukfsn.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <47D5BEE3.80109@gmail.com> <1205833527.826584.1207.nullmailer@galant.ukfsn.org> Cc: freebsd-bluetooth@freebsd.org Subject: Re: Bluetooth PAN support for FreeBSD X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2008 16:24:19 -0000 On 3/18/08, Iain Hibbert wrote: > On Mon, 17 Mar 2008, Maksim Yevmenkin wrote: > > > i have committed support for bnep based profiles into -current and > > have mfc'd it into releng_7 and _6. > > > +struct sdp_nap_profile > +{ > + uint16_t security_description; /* HBO: NAP/GN */ > + uint16_t net_access_type; /* HBO: NAP */ > + uint32_t max_net_access_rate; /* HBO: NAP */ > +}; > > what does HBO mean? host byte order. > also, why no PSM and load_factor ? > > uint16_t psm; > uint8_t load_factor; > > both would seem useful here.. well, psm comes from assigned numbers specification, i.e. 15. my initial concern was about "broken" devices, i.e. devices that do not make sdp query and simply use default psm. however, this is a bogus argument because if device does not use sdp it really does not matter what i put in there :) so, i really do not have very strong opinion about it. it is trivial to add if people want it. i did not add load_factor because i was not sure if anybody ever going to look at it. it is marked as optional. again, it is trivial to add if people want it. thanks, max