Date: Fri, 14 May 2010 02:25:53 +0200 From: Giovanni Trematerra <giovanni.trematerra@gmail.com> To: Brandon Gooch <jamesbrandongooch@gmail.com> Cc: freebsd-acpi@freebsd.org, freebsd-stable@freebsd.org Subject: Re: Kernel panic when unpluggin AC adaptor Message-ID: <AANLkTin3IucElH1cBEW8uGXRmetLvMeTx5GWzq3fjrz0@mail.gmail.com> In-Reply-To: <AANLkTim6vVdVFPRwZJk7hRfOSYMjMQyfjbfwG3t9uTsW@mail.gmail.com> References: <4DEBDE2C-C0D2-469D-AC42-DD5027926424@FreeBSD.org> <20100507120843.GA1738@Melon.malikania.fr> <k2u4e6cba831005070922vfc3bcf18i59551da3b40317a@mail.gmail.com> <1273257226.1671.3.camel@malikania.fr> <AANLkTilcNzzLt2GUPbL_Vqjspzx5a-oem1oZpKAYqoN8@mail.gmail.com> <AANLkTilq-j6y4QDwZScs0RVkHoZ9pUDk21quc36VIO1T@mail.gmail.com> <AANLkTimHK_Ho1qfoLO35GuxUFLLUux6CUNnIFxvMywIN@mail.gmail.com> <AANLkTiku4rZ0kuOC2ZWo11Sq_jhZSiMhDJDvLKyR0r4R@mail.gmail.com> <l2w3bbf2fe11005120741h4b3fdafape563a973a939bbe8@mail.gmail.com> <AANLkTim6vVdVFPRwZJk7hRfOSYMjMQyfjbfwG3t9uTsW@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015174410d60a4c7e048682ebd4 Content-Type: text/plain; charset=ISO-8859-1 On Thu, May 13, 2010 at 1:09 AM, Brandon Gooch <jamesbrandongooch@gmail.com> wrote: > On Wed, May 12, 2010 at 9:41 AM, Attilio Rao <attilio@freebsd.org> wrote: >> 2010/5/12 David DEMELIER <demelier.david@gmail.com>: >>> I remove the patch, and built the kernel (I updated the src this >>> morning) and it does not panic now. It's really odd. If it reappears >>> soon I will tell you. >> >> I looked at the code with Giovanni and I have the feeling that the >> race with the idle thread may still be fatal. >> We need to fix that. >> >> Attilio >> > > That seems to be the case, as my laptop shows about an 80-85 % chance > of experiencing a panic if left idle for long-ish periods of time (2 > to 4 hours). I usually rebuild world or big ports overnight, and more > often than not I wake up to a panicked machine, same situation every > time: > > ... > rman_get_bushandle() at rman_get_bushandle+0x1 > sched_idletd() at sched_idletd+0x123 > fork_exit() at fork_exit+0x12a > fork_trampoline() at fork_trampoline+0xe > ... > > The kernel/userland is rebuilt, the ports are finished compiling -- > it's in the time AFTER the completion of all tasks that the machine > gets bored and tries to kill itself :) > > I have seen the AC adapter plug/unplug "hang" in the past on this > laptop, but I never made the connection between the events, as > nowadays my laptop usually stays plugged in :( > > Attilio, I hope you can track this one down, let me know if I can do > anything to help or test... > Attilio and I came up with this patch. It seems ready for stress testing and review Please test and report back. Thank you P.S: all the faults are only mine. -- Gianni --0015174410d60a4c7e048682ebd4 Content-Type: text/plain; charset=US-ASCII; name="acpi_idle4.diff.txt" Content-Disposition: attachment; filename="acpi_idle4.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g969lyt20 ZGlmZiAtciBkN2QwZTA0ZjQyZTMgc3lzL2Rldi9hY3BpY2EvYWNwaV9jcHUuYwotLS0gYS9zeXMv ZGV2L2FjcGljYS9hY3BpX2NwdS5jCVdlZCBNYXkgMTIgMDQ6MDE6NTYgMjAxMCArMDIwMAorKysg Yi9zeXMvZGV2L2FjcGljYS9hY3BpX2NwdS5jCUZyaSBNYXkgMTQgMDI6MjA6MTggMjAxMCArMDIw MApAQCAtODgsNiArODgsNyBAQCBzdHJ1Y3QgYWNwaV9jcHVfc29mdGMgewogICAgIGludAkJCSBj cHVfY3hfbG93ZXN0OwogICAgIGNoYXIgCQkgY3B1X2N4X3N1cHBvcnRlZFs2NF07CiAgICAgaW50 CQkJIGNwdV9yaWQ7CisJc3RydWN0IG10eAkgY3B1X2xvY2s7CiB9OwogCiBzdHJ1Y3QgYWNwaV9j cHVfZGV2aWNlIHsKQEAgLTEwMCw2ICsxMDEsMTAgQEAgc3RydWN0IGFjcGlfY3B1X2RldmljZSB7 CiAjZGVmaW5lIENQVV9TRVRfUkVHKHJlZywgd2lkdGgsIHZhbCkJCQkJCVwKICAgICAoYnVzX3Nw YWNlX3dyaXRlXyAjIyB3aWR0aChybWFuX2dldF9idXN0YWcoKHJlZykpLCAJCQlcCiAJCSAgICAg ICBybWFuX2dldF9idXNoYW5kbGUoKHJlZykpLCAwLCAodmFsKSkpCisjZGVmaW5lIEFDUElfQ1BV X0xPQ0soc2MpIFwKKwltdHhfbG9ja19zcGluKCZzYy0+Y3B1X2xvY2spCisjZGVmaW5lIEFDUElf Q1BVX1VOTE9DSyhzYykgXAorCW10eF91bmxvY2tfc3Bpbigmc2MtPmNwdV9sb2NrKQogCiAjZGVm aW5lIFBNX1VTRUMoeCkJICgoeCkgPj4gMikJLyogfjQgY2xvY2tzIHBlciB1c2VjICgzLjU3OTU1 IE1oeikgKi8KIApAQCAtMjg0LDYgKzI4OSw3IEBAIGFjcGlfY3B1X2F0dGFjaChkZXZpY2VfdCBk ZXYpCiAgICAgQUNQSV9GVU5DVElPTl9UUkFDRSgoY2hhciAqKSh1aW50cHRyX3QpX19mdW5jX18p OwogCiAgICAgc2MgPSBkZXZpY2VfZ2V0X3NvZnRjKGRldik7CisJbXR4X2luaXQoJnNjLT5jcHVf bG9jaywgIm50ZmxjayIsIE5VTEwsIE1UWF9TUElOKTsKICAgICBzYy0+Y3B1X2RldiA9IGRldjsK ICAgICBzYy0+Y3B1X2hhbmRsZSA9IGFjcGlfZ2V0X2hhbmRsZShkZXYpOwogICAgIGNwdV9pZCA9 IChpbnQpKGludHB0cl90KWFjcGlfZ2V0X3ByaXZhdGUoZGV2KTsKQEAgLTQwOSwyNiArNDE1LDI2 IEBAIGFjcGlfY3B1X3Bvc3RhdHRhY2godm9pZCAqdW51c2VkIF9fdW51c2UKIFNZU0lOSVQoYWNw aV9jcHUsIFNJX1NVQl9DT05GSUdVUkUsIFNJX09SREVSX01JRERMRSwKICAgICBhY3BpX2NwdV9w b3N0YXR0YWNoLCBOVUxMKTsKIAotLyoKLSAqIERpc2FibGUgYW55IGVudHJ5IHRvIHRoZSBpZGxl IGZ1bmN0aW9uIGR1cmluZyBzdXNwZW5kIGFuZCByZS1lbmFibGUgaXQKLSAqIGR1cmluZyByZXN1 bWUuCi0gKi8KIHN0YXRpYyBpbnQKIGFjcGlfY3B1X3N1c3BlbmQoZGV2aWNlX3QgZGV2KQogewor ICAgIHN0cnVjdCBhY3BpX2NwdV9zb2Z0YyAqc2M7CiAgICAgaW50IGVycm9yOwogCisgICAgc2Mg PSBkZXZpY2VfZ2V0X3NvZnRjKGRldik7CiAgICAgZXJyb3IgPSBidXNfZ2VuZXJpY19zdXNwZW5k KGRldik7CiAgICAgaWYgKGVycm9yKQogCXJldHVybiAoZXJyb3IpOworCUFDUElfQ1BVX0xPQ0so c2MpOwogICAgIGNwdV9kaXNhYmxlX2lkbGUgPSBUUlVFOworCUFDUElfQ1BVX1VOTE9DSyhzYyk7 CisKICAgICByZXR1cm4gKDApOwogfQogCiBzdGF0aWMgaW50CiBhY3BpX2NwdV9yZXN1bWUoZGV2 aWNlX3QgZGV2KQogewotCiAgICAgY3B1X2Rpc2FibGVfaWRsZSA9IEZBTFNFOwogICAgIHJldHVy biAoYnVzX2dlbmVyaWNfcmVzdW1lKGRldikpOwogfQpAQCAtNjA5LDcgKzYxNSw5IEBAIGFjcGlf Y3B1X2dlbmVyaWNfY3hfcHJvYmUoc3RydWN0IGFjcGlfY3AKIAkgICAgY3hfcHRyLT50cmFuc19s YXQgPSBBY3BpR2JsX0ZBRFQuQzJMYXRlbmN5OwogCSAgICBjeF9wdHIrKzsKIAkgICAgc2MtPmNw dV9jeF9jb3VudCsrOwotCX0KKwl9IGVsc2UKKwkJcGFuaWMoIiVzOiBDYW5ub3QgYWxsb2NhdGUg cmVzb3VyY2UgJWQgZm9yIEMzIHN0YXRlIiwgX19mdW5jX18sIAorCQkgICAgY3hfcHRyLT5yZXNf dHlwZSk7CiAgICAgfQogICAgIGlmIChzYy0+Y3B1X3BfYmxrX2xlbiA8IDYpCiAJcmV0dXJuOwpA QCAtNjI1LDcgKzYzMyw5IEBAIGFjcGlfY3B1X2dlbmVyaWNfY3hfcHJvYmUoc3RydWN0IGFjcGlf Y3AKIAkgICAgY3hfcHRyLT50cmFuc19sYXQgPSBBY3BpR2JsX0ZBRFQuQzNMYXRlbmN5OwogCSAg ICBjeF9wdHIrKzsKIAkgICAgc2MtPmNwdV9jeF9jb3VudCsrOwotCX0KKwl9IGVsc2UKKwkJcGFu aWMoIiVzOiBDYW5ub3QgYWxsb2NhdGUgcmVzb3VyY2UgJWQgZm9yIEMzIHN0YXRlIiwgX19mdW5j X18sIAorCQkgICAgY3hfcHRyLT5yZXNfdHlwZSk7CiAgICAgfQogfQogCkBAIC03MjEsNiArNzMx LDggQEAgYWNwaV9jcHVfY3hfY3N0KHN0cnVjdCBhY3BpX2NwdV9zb2Z0YyAqcwogCX0KICNlbmRp ZgogCisJQUNQSV9DUFVfTE9DSyhzYyk7CisKIAkvKiBBbGxvY2F0ZSB0aGUgY29udHJvbCByZWdp c3RlciBmb3IgQzIgb3IgQzMuICovCiAJYWNwaV9Qa2dHYXMoc2MtPmNwdV9kZXYsIHBrZywgMCwg JmN4X3B0ci0+cmVzX3R5cGUsICZzYy0+Y3B1X3JpZCwKIAkgICAgJmN4X3B0ci0+cF9sdmx4LCBS Rl9TSEFSRUFCTEUpOwpAQCAtNzMyLDcgKzc0NCwxNyBAQCBhY3BpX2NwdV9jeF9jc3Qoc3RydWN0 IGFjcGlfY3B1X3NvZnRjICpzCiAJCQkgICAgIGN4X3B0ci0+dHJhbnNfbGF0KSk7CiAJICAgIGN4 X3B0cisrOwogCSAgICBzYy0+Y3B1X2N4X2NvdW50Kys7CisJCWNwdV9kaXNhYmxlX2lkbGUgPSBG QUxTRTsKKwl9IGVsc2UgeworCQlkZXZpY2VfcHJpbnRmKHNjLT5jcHVfZGV2LCAiY2Fubm90IGFs bG9jYXRlIGNvbnRyb2wgcmVnaXN0ZXIiCisJCSAgICAiIGZvciBDMiBvIEMzLiIpOworCisJCS8q CisJCSAqIGRpc2FibGUgYWNwaV9jcHVfaWRsZSBvdGhlcndpc2Ugd2UgZ2V0IGEgcGFuaWMKKwkJ ICovCisJCWNwdV9kaXNhYmxlX2lkbGUgPSBUUlVFOwogCX0KKwlBQ1BJX0NQVV9VTkxPQ0soc2Mp OwogICAgIH0KICAgICBBY3BpT3NGcmVlKGJ1Zi5Qb2ludGVyKTsKIApAQCAtOTAwLDYgKzkyMywx NSBAQCBhY3BpX2NwdV9pZGxlKCkKIAlyZXR1cm47CiAgICAgfQogCisJQUNQSV9DUFVfTE9DSyhz Yyk7CisKKyAgICAvKiBpbiB0aGUgbWVhbnRpbWUgYWNwaV9jcHVfbm90aWZ5IGNvdWxkIGJlIGRp c2FibGVkIHRoZSBob29rICovCisgICAgaWYgKGNwdV9kaXNhYmxlX2lkbGUpIHsKKwlBQ1BJX0NQ VV9VTkxPQ0soc2MpOworCUFDUElfRU5BQkxFX0lSUVMoKTsKKwlyZXR1cm47CisgICAgfQorCQog ICAgIC8qIEZpbmQgdGhlIGxvd2VzdCBzdGF0ZSB0aGF0IGhhcyBzbWFsbCBlbm91Z2ggbGF0ZW5j eS4gKi8KICAgICBjeF9uZXh0X2lkeCA9IDA7CiAgICAgZm9yIChpID0gc2MtPmNwdV9jeF9sb3dl c3Q7IGkgPj0gMDsgaS0tKSB7CkBAIC05MzUsNiArOTY3LDcgQEAgYWNwaV9jcHVfaWRsZSgpCiAg ICAgICovCiAgICAgaWYgKGN4X25leHQtPnR5cGUgPT0gQUNQSV9TVEFURV9DMSkgewogCXNjLT5j cHVfcHJldl9zbGVlcCA9IChzYy0+Y3B1X3ByZXZfc2xlZXAgKiAzICsgNTAwMDAwIC8gaHopIC8g NDsKKwlBQ1BJX0NQVV9VTkxPQ0soc2MpOwogCWFjcGlfY3B1X2MxKCk7CiAJcmV0dXJuOwogICAg IH0KQEAgLTk3NSw2ICsxMDA4LDcgQEAgYWNwaV9jcHVfaWRsZSgpCiAJQWNwaVdyaXRlQml0UmVn aXN0ZXIoQUNQSV9CSVRSRUdfQVJCX0RJU0FCTEUsIDApOwogCUFjcGlXcml0ZUJpdFJlZ2lzdGVy KEFDUElfQklUUkVHX0JVU19NQVNURVJfUkxELCAwKTsKICAgICB9CisJQUNQSV9DUFVfVU5MT0NL KHNjKTsKICAgICBBQ1BJX0VOQUJMRV9JUlFTKCk7CiAKICAgICAvKiBGaW5kIHRoZSBhY3R1YWwg dGltZSBhc2xlZXAgaW4gbWljcm9zZWNvbmRzLiAqLwo= --0015174410d60a4c7e048682ebd4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin3IucElH1cBEW8uGXRmetLvMeTx5GWzq3fjrz0>