From owner-freebsd-virtualization@FreeBSD.ORG Thu Jul 5 19:54:03 2012 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 349CD1065670; Thu, 5 Jul 2012 19:54:03 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by mx1.freebsd.org (Postfix) with ESMTP id 7FAD48FC0A; Thu, 5 Jul 2012 19:54:02 +0000 (UTC) Received: by wibhm11 with SMTP id hm11so29867wib.13 for ; Thu, 05 Jul 2012 12:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=a5/gNkxgRE5rLe/4iIKCRwd8wKtrJ4JNqCCD84MqWGU=; b=LnXoPnNlPd2rEv8jP4COVo4p5V3GxzJJaX98l8O9Mc4GPCBR8kNDAq5OPuL5mBtTZZ hqrDVidn9pd0mjTmdRqB4jAM3qMjsi//Qgfaft1aDVIN+h7/bWs3PLZMoM9qKJu1VWHy hzZ6OBnVX9+F6W8pXZ6H/MFTCXhI9xz/LDJ09vuTBxOlgyBDDxkFh3QHrtdwQKArwKSl 3sIxjEY/416DDTp0VxGTiIL/apMCWRQAje9/YTQebS9MVKlYkKBTpDRxm4uDU/pdhX3L ie74oO5v78geJ9nrF1hN/2QYm/MqMwG4voATa0ihTLe3TzuhLb9TKleAL8Ml/ElQFsUc A3pw== Received: by 10.216.144.69 with SMTP id m47mr9654014wej.86.1341518041630; Thu, 05 Jul 2012 12:54:01 -0700 (PDT) Received: from localhost ([95.69.175.25]) by mx.google.com with ESMTPS id y2sm1707546wix.7.2012.07.05.12.53.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 Jul 2012 12:54:00 -0700 (PDT) From: Mikolaj Golub To: d@delphij.net References: <4FF32FC4.6020701@delphij.net> <86wr2kau38.fsf@in138.ua3> <4FF5E87C.2020908@delphij.net> X-Comment-To: Xin Li Sender: Mikolaj Golub Date: Thu, 05 Jul 2012 22:53:58 +0300 In-Reply-To: <4FF5E87C.2020908@delphij.net> (Xin Li's message of "Thu, 05 Jul 2012 12:18:20 -0700") Message-ID: <86r4sqasrt.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Bjoern A. Zeeb" , freebsd-virtualization@FreeBSD.org Subject: Re: GPF when doing jail -r, possibly an use-after-free X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2012 19:54:03 -0000 On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: XL> Hi, Mikolaj, XL> On 07/04/12 00:00, Mikolaj Golub wrote: >> Is this observed after destroying epair? There is an issue with >> epair: on destroy, when epair_clone_destroy() calls >> ether_ifdetach() for its second half it does not switch to its vnet >> and if_detach_internal() can't find the interface and just returns. >> As a result V_ifnet list is left with dead reference. XL> Yes. >> http://lists.freebsd.org/pipermail/freebsd-virtualization/2011-January/000628.html >> >> Here is an updated patch against CURRENT: >> >> http://people.freebsd.org/~trociny/if_epair.c.epair_clone_destroy.1.patch XL> Your >> XL> patch did fixed the problem, thanks! Are you going to commit it XL> against -HEAD and then MFC after a while? I would like Bjoern review it before me committing, or at least tell he does not mind, if he does not have time to review -) -- Mikolaj Golub