Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Jun 2008 08:04:20 +0200
From:      Anton Berezin <tobez@tobez.org>
To:        Yen-Ming Lee <leeym@leeym.com>
Cc:        perl@freebsd.org
Subject:   Re: [PATCH] lang/p5-Error: update to 0.17014
Message-ID:  <20080627060420.GA63314@heechee.tobez.org>
In-Reply-To: <759236930806261359l4a520bdaqa5b8147daa4feec7@mail.gmail.com>
References:  <200806261912.m5QJCwVE009363@cn1.leeym.com> <4863F51A.6060309@p6m7g8.com> <759236930806261359l4a520bdaqa5b8147daa4feec7@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 26, 2008 at 01:59:49PM -0700, Yen-Ming Lee wrote:
> [cc'd to perl@ for more feedbacks]
> 
> 2008/6/26 Philip M. Gollucci <pgollucci@p6m7g8.com>:
> >> -.include <bsd.port.mk>
> >> +.include <bsd.port.pre.mk>
> >> +
> >> +.if ${PERL_LEVEL} < 500703
> >> +RUN_DEPENDS+=
> >>  p5-Scalar-List-Utils>=0:${PORTSDIR}/lang/p5-Scalar-List-Utils
> >> +.endif
> >> +
> >> +.include <bsd.port.post.mk>
> >
> > I thought we were deleting this, I know I've seen miwi@, lippe@, and some
> > others delete this.  lang/perl5.8 is the default and has this module in
> > CORE.
> >
> > This is more a general question that specific to this port.
> >
> > Update looks good.  Approved.
> 
> Yes, currently the default perl is 5.8.8, but we still support
> perl-.5.6.2, right ?
> Should we delete or keep these dependencies for perl-5.6.2 ?

I'd suggest we keep them, provided the port in question works with 5.6.
What I'd really like is to have the PERL_DEPENDS stuff we did with lth@ a
couple of month ago committed, then it would be possible to list
p5-Scalar-List-Utils as a dependency unconditionally and have the
bsd.perl.mk to decide whether it should be pulled in or not.

\Anton.
-- 
We're going for 'working' here. 'clean' is for people with skills...
-- Flemming Jacobsen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080627060420.GA63314>