From owner-cvs-all  Thu Nov 14 17:30: 5 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 337A137B401; Thu, 14 Nov 2002 17:30:04 -0800 (PST)
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8A59443E77; Thu, 14 Nov 2002 17:30:03 -0800 (PST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id RAA29917;
	Thu, 14 Nov 2002 17:16:14 -0800 (PST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gAF1GEOS032366;
	Thu, 14 Nov 2002 17:16:14 -0800 (PST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gAF1GEhq032365;
	Thu, 14 Nov 2002 17:16:14 -0800 (PST)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200211150116.gAF1GEhq032365@arch20m.dellroad.org>
Subject: Re: cvs commit: src/lib/libc_r/uthread uthread_execve.c
In-Reply-To: <Pine.GSO.4.10.10211141954130.13722-100000@pcnet1.pcnet.com>
To: Daniel Eischen <eischen@pcnet1.pcnet.com>
Date: Thu, 14 Nov 2002 17:16:14 -0800 (PST)
Cc: Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Daniel Eischen wrote:
> >   Modified files:
> >     lib/libc_r/uthread   uthread_execve.c 
> >   Log:
> >   When about to do an execve(), don't reset the O_NONBLOCK flag on any file
> >   descriptors that have the close-on-exec flag set, as that will have no
> >   effect anyway and might screw something else up if the file descriptor
> >   happens to be shared with another process.
> 
> I didn't like this change.  It was a hack to cover up some other
> problem.

But it was harmless, right? I figured it fixes some corner case without
causing any additional bugs so why not?

The real underlying problem doesn't seem solvable; I'd rather wait
until libc_r is KSE'ified.

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message