Date: Sat, 3 Mar 2001 09:46:32 +0100 From: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/w w.c Message-ID: <20010303094632.A666@daemon.ninth-circle.org> In-Reply-To: <200103030132.f231WkD54292@freefall.freebsd.org>; from ache@FreeBSD.org on Fri, Mar 02, 2001 at 05:32:46PM -0800 References: <200103030132.f231WkD54292@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-On [20010303 03:00], Andrey A. Chernov (ache@FreeBSD.org) wrote: > Log: > Don't use "," as load avg. separator because it can be precision point in some > locales, so leads to confusion Yeah that might be so. But the comma remains a logical seperator character for a lot of countries. If it confuses the locale then either the print statement is bogus or the locale has issues. A comma should just be able to be used. Also, w is the same as uptime, so you also modified the header output of uptime, which might break scripts, not sure though. Ok, so I thought a little further, some locales [English for example] use this for numbers: 10.12 to denote a fractional 12. So using output like: 0.25, 0.17, 0.14 is intuitive. However, for locales which use the comma for the fractions: 10,12 [e.g. Dutch], the output might be: 0,25, 0,17, 0,14. Ok, they might look awkward. But then looking at your changes you don't fix anything! You leave the %.2f in the printf statement! Which means that locales who use the comma as a fractional seperator get the dot anyway! Ergo, you have solved nothing so either rework this, or back this out, thanks. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I'm a child of the air, I'm a witch of the wind... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010303094632.A666>