From owner-freebsd-current Mon Feb 4 15:35:21 2002 Delivered-To: freebsd-current@freebsd.org Received: from avocet.prod.itd.earthlink.net (avocet.mail.pas.earthlink.net [207.217.120.50]) by hub.freebsd.org (Postfix) with ESMTP id 374C037B476; Mon, 4 Feb 2002 15:34:59 -0800 (PST) Received: from pool0476.cvx22-bradley.dialup.earthlink.net ([209.179.199.221] helo=mindspring.com) by avocet.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16XsdM-0005dB-00; Mon, 04 Feb 2002 15:34:49 -0800 Message-ID: <3C5F1A93.B83D7DAF@mindspring.com> Date: Mon, 04 Feb 2002 15:34:43 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: obrien@freebsd.org Cc: Mark Murray , current@FreeBSD.ORG Subject: Re: Panics in ffs_clusteracct with todays -current References: <20020205000829.A22758-100000@gamplex.bde.org> <200202041556.g14FuoE54487@greenpeace.grondar.org> <20020204092640.A9832@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien wrote: > > If this fixes a problem, then please go ahead and commit it. :-) > > Many reasons to not rush this: > > Maybe because we are in the middle of a discussion. > Maybe to educate others why the change was bad so others will not attempt > the same change later. > Maybe the person that made the change does not agree with the analysis and > wants to fix things a different way. I have to agree with David; there had to be some reason involved in the change in the first place. I can think of a couple of reasons, haviong to do with sign extended math, which might prompt the change. It may be that Alfred's fix is the best one, despite the risks Bruce has identified. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message