From owner-freebsd-ports@FreeBSD.ORG Tue Apr 19 05:27:46 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 711BA16A4CE for ; Tue, 19 Apr 2005 05:27:46 +0000 (GMT) Received: from bsd.dino.sk (bsd.dino.sk [213.215.72.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06AA543D1F for ; Tue, 19 Apr 2005 05:27:45 +0000 (GMT) (envelope-from ports@dino.sk) Received: from [213.215.74.194] ([213.215.74.194]) (AUTH: LOGIN milan) by bsd.dino.sk with esmtp; Tue, 19 Apr 2005 07:28:51 +0200 id 000000C0.42649713.000166E7 From: Milan Obuch To: freebsd-ports@freebsd.org Date: Tue, 19 Apr 2005 07:27:36 +0200 User-Agent: KMail/1.6.2 References: <20050414111426.775f6afd.lehmann@ans-netz.de> <200504182141.50312.ports@dino.sk> <20050419022949.112b35e2.lehmann@ans-netz.de> In-Reply-To: <20050419022949.112b35e2.lehmann@ans-netz.de> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200504190727.36336.ports@dino.sk> Subject: Re: splitting courier-authlib into master+slave ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2005 05:27:46 -0000 On Tuesday 19 April 2005 02:29, Oliver Lehmann wrote: > Milan Obuch wrote: > > First, there is small bug when installing courier-authlib - installed > > authdaemonrc lists all possible authentication modules, which is not > > really what most users want - they would like list only installed > > modules. > > courier-authlib will only use the installed modules... even if more > modules are listed so I see no problem? > Technically, none. Administratively, it is a bit misleading offering for use something not installed on the system. Taken from authdaemonrc: ##NAME: authmodulelist:2 # # The authentication modules that are linked into authdaemond. The # default list is installed. You may selectively disable modules simply # by removing them from the following list. The available modules you # can use are: authuserdb authpam authpwd authldap authmysql authpgsql authvchkpw authmodulelist="authuserdb authpam authpwd authldap authmysql authpgsql authvchkpw" ##NAME: authmodulelistorig:2 # # This setting is used by Courier's webadmin module, and should be left # alone authmodulelistorig="authuserdb authpam authpwd authldap authmysql authpgsql authvchkpw" Note explicitly telling 'available modules...' which is plain wrong. Those modules are not available because they are not installed at all, only a subset from them is. For not-so-skilled administrator this could lead to painfull looking for error source. One more notice at this - current courier-authlib port generates both authmodulelist and authmodulelistorig according to options selected, I think this behaviour should not change, because it is perfectly understandable and clear, no misleading offering. > > Second, it would be nice if, after installing courier-authlib, user gets > > message saying 'only basic authpwd module installed, consider adding > > courier-authlib-??? package'. > > I'll think about it. > Maybe pkg-message? If someone installs only courier-authlib, he sees that so he is reminded something could be missing (if he is used to current behaviour). Other than those two points, I think idea of splitting courier-authlib into subports is good. Maybe move from ports/mail to ports/security should be emphasized, too. > > Third, when additional authentication module is installed, 'make > > deinstall' in main port should not delete courier-authlib when not > > explicitly forced. I think this should be justified. > > That is "works as designed". Try any other port... if you want to change > that behaviour, fix bsd.port.mk and send-pr But that behaviour will > remain I guess ;) OK, lesson taken. No more objection there. I just did not observe difference between 'make deinstall' and 'pkg_delete'. What about my other suggestion for using configure with one more '--cache-file=/tmp/courier.cache' argument? This recommendation comes actually from courier-users mailing list, and speeds up a lot whole installation process. Only drawback is possibility for using bad cached configure cache, which could be easily adjusted by first removing it. Or maybe it could be located in workdir. I would like to see this added. I just did a test - with this option added it took 8:35, without 11:00. Not a scientific test, but if someone would like to add one or more subports, gain is more. Gain will be even more signifficant if cache could be reused for all compilations for both main port and slave ports, but I have no idea now how to achieve this safely. Regards, Milan