From owner-freebsd-ports Thu Feb 21 15:34:58 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by hub.freebsd.org (Postfix) with ESMTP id 73E9237B400; Thu, 21 Feb 2002 15:34:51 -0800 (PST) Received: from fwd04.sul.t-online.de by mailout11.sul.t-online.com with smtp id 16e2bz-0005Nv-07; Fri, 22 Feb 2002 00:26:51 +0100 Received: from spirit.corecode.ath.cx (320050403952-0001@[217.224.172.92]) by fmrl04.sul.t-online.com with esmtp id 16e2bw-11rkGWC; Fri, 22 Feb 2002 00:26:48 +0100 Received: from elevation.zuhause.stoert.net (elevation.zuhause.stoert.net [192.168.66.46]) by spirit.corecode.ath.cx (8.11.6/8.11.6) with ESMTP id g1LNQlg47630; Fri, 22 Feb 2002 00:26:47 +0100 (CET) (envelope-from corecode@corecode.ath.cx) Received: (from corecode@localhost) by elevation.zuhause.stoert.net (8.11.6/8.11.6) id g1LNQk970941; Fri, 22 Feb 2002 00:26:46 +0100 (CET) (envelope-from corecode) Date: Fri, 22 Feb 2002 00:26:42 +0100 From: "Simon 'corecode' Schubert" To: Maxim Sobolev Cc: drosih@rpi.edu, freebsd-ports@FreeBSD.ORG Subject: Re: Speeding up bsd.ports.mk Message-Id: <20020222002642.50912e5c.corecode@corecode.ath.cx> In-Reply-To: <3C7544E3.2CC013B4@FreeBSD.org> References: <3C73F34F.D9A58E8B@FreeBSD.org> <3C74B745.9D57D6A9@FreeBSD.org> <3C74BF4E.480E1D39@FreeBSD.org> <3C75260E.1F72E9F6@FreeBSD.org> <3C7544E3.2CC013B4@FreeBSD.org> X-Mailer: Sylpheed version 0.7.2claws (GTK+ 1.2.10; i386--freebsd4.5) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=.H6/Iv369LQK0qN" X-Sender: 320050403952-0001@t-dialin.net Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --=.H6/Iv369LQK0qN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 Feb 2002 21:05:07 +0200 Maxim Sobolev wrote: > Thank you for giving it a try - your help is really appreciated! i did not yet test it - but i believe this patch may break building ports which utilize dialog(1) to change the port building options: it usually works this way: $ make all v - make pre-{everything|fetch|extract} -> config script builds Makefile.inc - other make commands launched include now Makefile.inc because of a .if exists(Makefile.inc) .include "Makefile.inc" .endif this means sub-makes after the config script will suck in the just generated settings. this won't work any more if each step is not launched seperately but processed from within one make(1) process. this at least affects 22 ports (simple grep ".include.*WRKDIR"|wc told this) and i think this is serious because IMO more ports should use dialog(1) when !defined(BATCH). (btw: also IMO ports with dialogs shouldn't default to some values when built -DBATCH but just should be skipped [see the ports.mk: IS_INTERACTIVE"], but this is another thing) unfortunately i don't have any time for the next weeks to test this. cheerz corecode -- /"\ http://corecode.ath.cx/ \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News --=.H6/Iv369LQK0qN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) iD8DBQE8dYI2r5S+dk6z85oRApIsAJ96Jor4GCmbhpny2Zn97lF7nQ+HcACgn7E1 //Fb5Wusj8Re1X/6V/Ri9VI= =8awc -----END PGP SIGNATURE----- --=.H6/Iv369LQK0qN-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message