Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Feb 2002 00:26:42 +0100
From:      "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To:        Maxim Sobolev <sobomax@FreeBSD.ORG>
Cc:        drosih@rpi.edu, freebsd-ports@FreeBSD.ORG
Subject:   Re: Speeding up bsd.ports.mk
Message-ID:  <20020222002642.50912e5c.corecode@corecode.ath.cx>
In-Reply-To: <3C7544E3.2CC013B4@FreeBSD.org>
References:  <3C73F34F.D9A58E8B@FreeBSD.org> <a51k3b$31a$1@kemoauc.mips.inka.de> <3C74B745.9D57D6A9@FreeBSD.org> <3C74BF4E.480E1D39@FreeBSD.org> <3C75260E.1F72E9F6@FreeBSD.org> <p05101410b89ae610a56c@[128.113.24.47]> <3C7544E3.2CC013B4@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=.H6/Iv369LQK0qN
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 21 Feb 2002 21:05:07 +0200 Maxim Sobolev <sobomax@FreeBSD.ORG>
wrote:
 
> Thank you for giving it a try - your help is really appreciated!

i did not yet test it - but i believe this patch may break building
ports which utilize dialog(1) to change the port building options:

it usually works this way:

$ make all
  v
  - make pre-{everything|fetch|extract} -> config script builds
                                           Makefile.inc
  - other make commands launched include now Makefile.inc because of a
    .if exists(Makefile.inc)
    .include "Makefile.inc"
    .endif
    this means sub-makes after the config script will suck in the just
    generated settings.

this won't work any more if each step is not launched seperately but
processed from within one make(1) process.

this at least affects 22 ports (simple grep ".include.*WRKDIR"|wc told
this) and i think this is serious because IMO more ports should use
dialog(1) when !defined(BATCH). (btw: also IMO ports with dialogs
shouldn't default to some values when built -DBATCH but just should be
skipped [see the ports.mk: IS_INTERACTIVE"], but this is another thing)

unfortunately i don't have any time for the next weeks to test this.

cheerz
  corecode

-- 
/"\   http://corecode.ath.cx/
\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News

--=.H6/Iv369LQK0qN
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)

iD8DBQE8dYI2r5S+dk6z85oRApIsAJ96Jor4GCmbhpny2Zn97lF7nQ+HcACgn7E1
//Fb5Wusj8Re1X/6V/Ri9VI=
=8awc
-----END PGP SIGNATURE-----

--=.H6/Iv369LQK0qN--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020222002642.50912e5c.corecode>