From owner-cvs-all Thu Jan 24 11:20:11 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id 30B3A37B41D; Thu, 24 Jan 2002 11:20:07 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020124192006.OQAF3578.rwcrmhc52.attbi.com@InterJet.elischer.org>; Thu, 24 Jan 2002 19:20:06 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA28302; Thu, 24 Jan 2002 11:05:17 -0800 (PST) Date: Thu, 24 Jan 2002 11:05:16 -0800 (PST) From: Julian Elischer To: Guido van Rooij Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb umass.c In-Reply-To: <20020124185841.GA63552@gvr.gvr.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG If you guys are working on the USB code, cound you look into shrinking the stack usage in it? check out the stack-hogs link off http:/www.freebsd.org/~julian/ usb code features heavily. On Thu, 24 Jan 2002, Guido van Rooij wrote: > On Thu, Jan 24, 2002 at 04:19:13PM +0000, Josef Karthauser wrote: > > > Modified files: > > > sys/dev/usb umass.c > > > Log: > > > 1) Fix a debug statement by filling in its data before the printf in > > > stead of after > > > 2) Honour NO_TEST_UNIT_READY quirk for atapi devices as well > > > 3) Actually support FujiFilm FinePix 6800 camera's. Will very likely also > > > work for other FinePix models. > > > > > > Based on a debug session about half a year ago with Nik Hibma. > > > MFC after: 2 weeks > > > > Hi Guido, > > > > This is a big change. I'd appreciate it if in future an USB patches > > were run by me first. I've been working hard to sychronise the USB > > stack with the NetBSD code. You don't mention here whether this code > > came from NetBSD or was developed in house. If the latter then we > > need to get these patches back to NetBSD, if the former it's good idea > > to mention the revision numbers in the commit. > > Sorry, you are right here. It is just that it was developped in a session > with Nik when he was still `in charge'. It just never was commited. > And since I had to change the code a bit because of the restructuring in > the am error processing, I was thinking: let's have it comitted asap. > It was developped in-house, and, as you can see, it is a real quirk: > apparently, these devices do not clear the Unit Attention state on > a request_sense command. > > -Guido > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message