Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Nov 2010 17:36:05 -0800
From:      Pyun YongHyeon <pyunyh@gmail.com>
To:        Bruce Cran <bruce@cran.org.uk>
Cc:        freebsd-net@freebsd.org
Subject:   Re: if_msk not working after suspend/resume if only one adapter is present
Message-ID:  <20101116013605.GH1257@michelle.cdnetworks.com>
In-Reply-To: <201011152311.42968.bruce@cran.org.uk>
References:  <201011152311.42968.bruce@cran.org.uk>

next in thread | previous in thread | raw e-mail | index | archive | help

--E13BgyNx05feLLmH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 15, 2010 at 11:11:42PM +0000, Bruce Cran wrote:
> I've been trying to get suspend/resume working on my Dell laptop.  I have two 
> if_msk adapters: one's the built-in 100Mb port and the other's a Sonnet Gb 
> ExpressCard NIC. I've noticed that if I boot with the Gb card installed both 
> ports work fine when the laptop has been resumed but if I don't have the Gb 
> card installed then the built-in port stops working.   Is there any way to 
> debug what might be going wrong?
> 

Could you show me dmesg output?
I've attached a blind patch which could be related with
suspend/resume. I guess powering down code was not synchronized
well for newer controllers.

--E13BgyNx05feLLmH
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="msk.pdown.diff"

Index: sys/dev/msk/if_msk.c
===================================================================
--- sys/dev/msk/if_msk.c	(revision 215345)
+++ sys/dev/msk/if_msk.c	(working copy)
@@ -2941,8 +2941,6 @@
 	CSR_WRITE_4(sc, B0_HWE_IMSK, 0);
 	CSR_READ_4(sc, B0_HWE_IMSK);
 
-	msk_phy_power(sc, MSK_PHY_POWERDOWN);
-
 	/* Put hardware reset. */
 	CSR_WRITE_2(sc, B0_CTST, CS_RST_SET);
 	sc->msk_pflags |= MSK_FLAG_SUSPEND;

--E13BgyNx05feLLmH--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101116013605.GH1257>