From owner-cvs-all Wed Jul 17 7:21:56 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 690D837B400; Wed, 17 Jul 2002 07:21:51 -0700 (PDT) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17F1843E31; Wed, 17 Jul 2002 07:21:50 -0700 (PDT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id JAA14765; Wed, 17 Jul 2002 09:12:46 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g6HDCG253364; Wed, 17 Jul 2002 09:12:16 -0400 (EDT) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15669.27952.598634.585316@grasshopper.cs.duke.edu> Date: Wed, 17 Jul 2002 09:12:16 -0400 (EDT) To: Bruce Evans Cc: John Baldwin , , Subject: RE: cvs commit: src/sys/kern kern_condvar.c kern_shutdown.c kern In-Reply-To: <20020717164015.J4112-100000@gamplex.bde.org> References: <20020717164015.J4112-100000@gamplex.bde.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > On Tue, 16 Jul 2002, John Baldwin wrote: > > > On 17-Jul-2002 Andrew Gallatin wrote: > > > gallatin 2002/07/16 19:23:44 PDT > > > > > > Modified files: > > > sys/kern kern_condvar.c kern_shutdown.c > > > kern_switch.c kern_synch.c > > > sys/sys proc.h > > > Log: > > > Allow alphas to do crashdumps: Refuse to run anything in choosethread() > > > after a panic which is not an interrupt thread, or the thread which > > > caused the panic. Also, remove panicstr checks from msleep() and from > > > cv_wait() in order to allow threads to go to sleep and yeild the cpu > > > to the panicing thread, or to an interrupt thread which might > > > be doing the crashdump. > > > > > > Reviewed by: jhb (and it was mostly his idea too) > > > > You might want to integrate some of bde's suggestions on fixing up > > comments, etc. > > Also ones to not fix it this way :-). Only the panicing thread should > run once panic() is reached. The crashdump part of panic came close > to doing this in RELENG_4 but has rotted. I whole-heartedly agree with you. But fixing things to work correctly is way beyond the amount of time I have available. My sole intent was to put enough of a bandaid on this so that crashdumps work again on alpha. In terms of bitrot removal in the comments, would the removal of the second sentence of the following comment in both msleep() and its clone in cv_timedwait() be sufficient? /* * During autoconfiguration, just give interrupts * a chance, then just return. * Don't run any other procs or panic below, * in case this is the idle process and already asleep. */ Becomes: /* During autoconfiguration, just return */ Thanks, Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message