From owner-cvs-all@FreeBSD.ORG  Thu Oct 23 00:37:33 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EBFD216A4B3; Thu, 23 Oct 2003 00:37:33 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 01F5143F93; Thu, 23 Oct 2003 00:37:33 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.9p2/8.12.9) with ESMTP id h9N7bSE7047959;
	Thu, 23 Oct 2003 01:37:28 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 23 Oct 2003 01:34:23 -0600 (MDT)
Message-Id: <20031023.013423.02875687.imp@bsdimp.com>
To: des@des.no
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <xzpfzhkh10t.fsf@dwp.des.no>
References: <20031022213712.S60963@root.org>
	<20031022.235525.122825408.imp@bsdimp.com>
	<xzpfzhkh10t.fsf@dwp.des.no>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: nate@root.org
Subject: Re: cvs commit: src/sys/dev/ep if_ep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 07:37:34 -0000

In message: <xzpfzhkh10t.fsf@dwp.des.no>
            des@des.no (Dag-Erling Sm=F8rgrav) writes:
: "M. Warner Losh" <imp@bsdimp.com> writes:
: > caddr_t is right: it is a character pointer.  uintptr_t is somethin=
g
: > else.  caddr_t is what was used before.
: =

: caddr_t is never right.  If it's a character pointer, use char *.

Why not?  The rest of the driver uses it heavily, and the data type of
the underlying mbufs is caddr_t:

#define	mtod(m, t)	((t)((m)->m_data))

struct m_hdr {
	struct	mbuf *mh_next;		/* next buffer in chain */
	struct	mbuf *mh_nextpkt;	/* next chain in queue/record */
	caddr_t	mh_data;		/* location of data */
	int	mh_len;			/* amount of data in this mbuf */
	int	mh_flags;		/* flags; see below */
	short	mh_type;		/* type of data in this mbuf */
};
struct mbuf {
	struct	m_hdr m_hdr;
...
#define	m_data		m_hdr.mh_data
...

Warner