Date: Sun, 19 Apr 2015 19:57:22 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: FreeBSD Filesystems <freebsd-fs@freebsd.org> Subject: Patch that defines MAXBCACHEBUF separate from MAXBSIZE for review Message-ID: <1552767461.21885039.1429487842728.JavaMail.root@uoguelph.ca> In-Reply-To: <963641485.21885012.1429487839649.JavaMail.root@uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_21885037_470978965.1429487842726 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, MAXBSIZE is both the maximum UFS block size and the maximum size of a buffer cache block. This patch defines MAXBCACHEBUF as a separate constant that is the maximum size of a buffer cache block. This allows it to be set on a per-architecture basis and, therefore, can be made larger than MAXBSIZE so that the NFS client can do larger reads/writes, for 64bit architectures. The patch is here for review: https://reviews.freebsd.org/D2330 and is also attached. Since I've never used Phabricator, I suspect it's messed up, but just email if you want to review this or comment and can't do it in phabricator. rick ------=_Part_21885037_470978965.1429487842726 Content-Type: text/x-patch; name=buftune2.patch Content-Disposition: attachment; filename=buftune2.patch Content-Transfer-Encoding: base64 LS0tIGtlcm4vdmZzX2Jpby5jLnNhdmJ1ZgkyMDE1LTAzLTMwIDIxOjI0OjM5LjAwMDAwMDAwMCAt MDQwMAorKysga2Vybi92ZnNfYmlvLmMJMjAxNS0wNC0xOCAxNzo1NToxNi4wMDAwMDAwMDAgLTA0 MDAKQEAgLTgwNSw2ICs4MDUsNyBAQCBidWZpbml0KHZvaWQpCiAJc3RydWN0IGJ1ZiAqYnA7CiAJ aW50IGk7CiAKKwlDVEFTU0VSVChNQVhCQ0FDSEVCVUYgPj0gTUFYQlNJWkUpOwogCW10eF9pbml0 KCZicWNsZWFuLCAiYnVmcSBjbGVhbiBsb2NrIiwgTlVMTCwgTVRYX0RFRik7CiAJbXR4X2luaXQo JmJxZGlydHksICJidWZxIGRpcnR5IGxvY2siLCBOVUxMLCBNVFhfREVGKTsKIAltdHhfaW5pdCgm cmJyZXFsb2NrLCAicnVubmluZ2J1ZnNwYWNlIGxvY2siLCBOVUxMLCBNVFhfREVGKTsKQEAgLTg0 Niw4ICs4NDcsOCBAQCBidWZpbml0KHZvaWQpCiAJICogYnkgdGhlIHN5c3RlbS4KIAkgKi8KIAlt YXhidWZzcGFjZSA9IChsb25nKW5idWYgKiBCS1ZBU0laRTsKLQloaWJ1ZnNwYWNlID0gbG1heCgz ICogbWF4YnVmc3BhY2UgLyA0LCBtYXhidWZzcGFjZSAtIE1BWEJTSVpFICogMTApOwotCWxvYnVm c3BhY2UgPSBoaWJ1ZnNwYWNlIC0gTUFYQlNJWkU7CisJaGlidWZzcGFjZSA9IGxtYXgoMyAqIG1h eGJ1ZnNwYWNlIC8gNCwgbWF4YnVmc3BhY2UgLSBNQVhCQ0FDSEVCVUYgKiAxMCk7CisJbG9idWZz cGFjZSA9IGhpYnVmc3BhY2UgLSBNQVhCQ0FDSEVCVUY7CiAKIAkvKgogCSAqIE5vdGU6IFRoZSAx NiBNaUIgdXBwZXIgbGltaXQgZm9yIGhpcnVubmluZ3NwYWNlIHdhcyBjaG9zZW4KQEAgLTg1Nyw5 ICs4NTgsOSBAQCBidWZpbml0KHZvaWQpCiAJICogVGhlIGxvd2VyIDEgTWlCIGxpbWl0IGlzIHRo ZSBoaXN0b3JpY2FsIHVwcGVyIGxpbWl0IGZvcgogCSAqIGhpcnVubmluZ3NwYWNlLgogCSAqLwot CWhpcnVubmluZ3NwYWNlID0gbG1heChsbWluKHJvdW5kdXAoaGlidWZzcGFjZSAvIDY0LCBNQVhC U0laRSksCisJaGlydW5uaW5nc3BhY2UgPSBsbWF4KGxtaW4ocm91bmR1cChoaWJ1ZnNwYWNlIC8g NjQsIE1BWEJDQUNIRUJVRiksCiAJICAgIDE2ICogMTAyNCAqIDEwMjQpLCAxMDI0ICogMTAyNCk7 Ci0JbG9ydW5uaW5nc3BhY2UgPSByb3VuZHVwKChoaXJ1bm5pbmdzcGFjZSAqIDIpIC8gMywgTUFY QlNJWkUpOworCWxvcnVubmluZ3NwYWNlID0gcm91bmR1cCgoaGlydW5uaW5nc3BhY2UgKiAyKSAv IDMsIE1BWEJDQUNIRUJVRik7CiAKIC8qCiAgKiBMaW1pdCB0aGUgYW1vdW50IG9mIG1hbGxvYyBt ZW1vcnkgc2luY2UgaXQgaXMgd2lyZWQgcGVybWFuZW50bHkgaW50bwpAQCAtMzA3Myw4ICszMDc0 LDkgQEAgZ2V0YmxrKHN0cnVjdCB2bm9kZSAqdnAsIGRhZGRyX3QgYmxrbm8sIAogCUtBU1NFUlQo KGZsYWdzICYgKEdCX1VOTUFQUEVEIHwgR0JfS1ZBQUxMT0MpKSAhPSBHQl9LVkFBTExPQywKIAkg ICAgKCJHQl9LVkFBTExPQyBvbmx5IG1ha2VzIHNlbnNlIHdpdGggR0JfVU5NQVBQRUQiKSk7CiAJ QVNTRVJUX1ZPUF9MT0NLRUQodnAsICJnZXRibGsiKTsKLQlpZiAoc2l6ZSA+IE1BWEJTSVpFKQot CQlwYW5pYygiZ2V0YmxrOiBzaXplKCVkKSA+IE1BWEJTSVpFKCVkKVxuIiwgc2l6ZSwgTUFYQlNJ WkUpOworCWlmIChzaXplID4gTUFYQkNBQ0hFQlVGKQorCQlwYW5pYygiZ2V0YmxrOiBzaXplKCVk KSA+IE1BWEJDQUNIRUJVRiglZClcbiIsIHNpemUsCisJCSAgICBNQVhCQ0FDSEVCVUYpOwogCWlm ICghdW5tYXBwZWRfYnVmX2FsbG93ZWQpCiAJCWZsYWdzICY9IH4oR0JfVU5NQVBQRUQgfCBHQl9L VkFBTExPQyk7CiAKLS0tIGZzL25mc2NsaWVudC9uZnNfY2x2ZnNvcHMuYy5zYXZidWYJMjAxNS0w NC0xNyAxNzoyNTowMS4wMDAwMDAwMDAgLTA0MDAKKysrIGZzL25mc2NsaWVudC9uZnNfY2x2ZnNv cHMuYwkyMDE1LTA0LTE4IDE4OjAyOjI1LjAwMDAwMDAwMCAtMDQwMApAQCAtMjAxLDE2ICsyMDEs MTYgQEAgbmV3bmZzX2lvc2l6ZShzdHJ1Y3QgbmZzbW91bnQgKm5tcCkKIAl9CiAJaWYgKG5tcC0+ bm1fcnNpemUgPiBtYXhpbyB8fCBubXAtPm5tX3JzaXplID09IDApCiAJCW5tcC0+bm1fcnNpemUg PSBtYXhpbzsKLQlpZiAobm1wLT5ubV9yc2l6ZSA+IE1BWEJTSVpFKQotCQlubXAtPm5tX3JzaXpl ID0gTUFYQlNJWkU7CisJaWYgKG5tcC0+bm1fcnNpemUgPiBORlNfTUFYQlNJWkUpCisJCW5tcC0+ bm1fcnNpemUgPSBORlNfTUFYQlNJWkU7CiAJaWYgKG5tcC0+bm1fcmVhZGRpcnNpemUgPiBtYXhp byB8fCBubXAtPm5tX3JlYWRkaXJzaXplID09IDApCiAJCW5tcC0+bm1fcmVhZGRpcnNpemUgPSBt YXhpbzsKIAlpZiAobm1wLT5ubV9yZWFkZGlyc2l6ZSA+IG5tcC0+bm1fcnNpemUpCiAJCW5tcC0+ bm1fcmVhZGRpcnNpemUgPSBubXAtPm5tX3JzaXplOwogCWlmIChubXAtPm5tX3dzaXplID4gbWF4 aW8gfHwgbm1wLT5ubV93c2l6ZSA9PSAwKQogCQlubXAtPm5tX3dzaXplID0gbWF4aW87Ci0JaWYg KG5tcC0+bm1fd3NpemUgPiBNQVhCU0laRSkKLQkJbm1wLT5ubV93c2l6ZSA9IE1BWEJTSVpFOwor CWlmIChubXAtPm5tX3dzaXplID4gTkZTX01BWEJTSVpFKQorCQlubXAtPm5tX3dzaXplID0gTkZT X01BWEJTSVpFOwogCiAJLyoKIAkgKiBDYWxjdWxhdGUgdGhlIHNpemUgdXNlZCBmb3IgaW8gYnVm ZmVycy4gIFVzZSB0aGUgbGFyZ2VyCi0tLSBmcy9uZnMvbmZzcG9ydC5oLnNhdmJ1ZgkyMDE1LTAz LTMwIDIxOjUxOjA1LjAwMDAwMDAwMCAtMDQwMAorKysgZnMvbmZzL25mc3BvcnQuaAkyMDE1LTAz LTMwIDIxOjUxOjM4LjAwMDAwMDAwMCAtMDQwMApAQCAtOTUyLDcgKzk1Miw3IEBAIHN0cnVjdCBu ZnNyZXEgewogfTsKIAogI2lmbmRlZiBORlNfTUFYQlNJWkUKLSNkZWZpbmUJTkZTX01BWEJTSVpF CU1BWEJTSVpFCisjZGVmaW5lCU5GU19NQVhCU0laRQlNQVhCQ0FDSEVCVUYKICNlbmRpZgogCiAv KgotLS0gc3lzL3BhcmFtLmguc2F2YnVmCTIwMTUtMDMtMjcgMjI6MTA6MTQuMDAwMDAwMDAwIC0w NDAwCisrKyBzeXMvcGFyYW0uaAkyMDE1LTA0LTE5IDA4OjUxOjIyLjAwMDAwMDAwMCAtMDQwMApA QCAtMjMzLDEwICsyMzMsMTkgQEAKICAqCQlhbmQgbWF5IGJlIG1hZGUgc21hbGxlciBhdCB0aGUg cmlzayBvZiBub3QgYmVpbmcgYWJsZSB0byB1c2UKICAqCQlmaWxlc3lzdGVtcyB3aGljaCByZXF1 aXJlIGEgYmxvY2sgc2l6ZSBleGNlZWRpbmcgTUFYQlNJWkUuCiAgKgorICogTUFYQkNBQ0hFQlVG IC0gTWF4aW11bSBzaXplIG9mIGEgYnVmZmVyIGluIHRoZSBidWZmZXIgY2FjaGUuICBUaGlzIG11 c3QKKyAqCQliZSA+PSBNQVhCU0laRSBhbmQgY2FuIGJlIHNldCBkaWZmZXJlbnRseSBmb3IgZGlm ZmVyZW50CisgKgkJYXJjaGl0ZWN0dXJlcyBieSBkZWZpbmluZyBpdCBpbiA8bWFjaGluZS9wYXJh bS5oPi4KKyAqCQlNYWtpbmcgdGhpcyBsYXJnZXIgYWxsb3dzIE5GUyB0byBkbyBsYXJnZXIgcmVh ZHMvd3JpdGVzLgorICoKICAqIEJLVkFTSVpFIC0JTm9taW5hbCBidWZmZXIgc3BhY2UgcGVyIGJ1 ZmZlciwgaW4gYnl0ZXMuICBCS1ZBU0laRSBpcyB0aGUKICAqCQltaW5pbXVtIEtWTSBtZW1vcnkg cmVzZXJ2YXRpb24gdGhlIGtlcm5lbCBpcyB3aWxsaW5nIHRvIG1ha2UuCiAgKgkJRmlsZXN5c3Rl bXMgY2FuIG9mIGNvdXJzZSByZXF1ZXN0IHNtYWxsZXIgY2h1bmtzLiAgQWN0dWFsIAogICoJCWJh Y2tpbmcgbWVtb3J5IHVzZXMgYSBjaHVuayBzaXplIG9mIGEgcGFnZSAoUEFHRV9TSVpFKS4KKyAq CQlUaGUgZGVmYXVsdCB2YWx1ZSBoZXJlIGNhbiBiZSBvdmVycmlkZGVuIG9uIGEgcGVyLWFyY2hp dGVjdHVyZQorICoJCWJhc2lzIGJ5IGRlZmluaW5nIGl0IGluIDxtYWNoaW5lL3BhcmFtLmg+LiAg VGhpcyBzaG91bGQKKyAqCQlwcm9iYWJseSBiZSBkb25lIHRvIGluY3JlYXNlIGl0cyB2YWx1ZSwg d2hlbiBNQVhCQ0FDSEVCVUYgaXMKKyAqCQlkZWZpbmVkIGFzIGEgbGFyZ2VyIHZhbHVlIGluIDxt YWNoaW5lL3BhcmFtLmg+LgogICoKICAqCQlJZiB5b3UgbWFrZSBCS1ZBU0laRSB0b28gc21hbGwg eW91IHJpc2sgc2VyaW91c2x5IGZyYWdtZW50aW5nCiAgKgkJdGhlIGJ1ZmZlciBLVk0gbWFwIHdo aWNoIG1heSBzbG93IHRoaW5ncyBkb3duIGEgYml0LiAgSWYgeW91CkBAIC0yNDgsNyArMjU3LDEy IEBACiAgKgkJbm9ybWFsIFVGUyBmaWxlc3lzdGVtLgogICovCiAjZGVmaW5lIE1BWEJTSVpFCTY1 NTM2CS8qIG11c3QgYmUgcG93ZXIgb2YgMiAqLworI2lmbmRlZglNQVhCQ0FDSEVCVUYKKyNkZWZp bmUJTUFYQkNBQ0hFQlVGCU1BWEJTSVpFIC8qIG11c3QgYmUgYSBwb3dlciBvZiAyID49IE1BWEJT SVpFICovCisjZW5kaWYKKyNpZm5kZWYJQktWQVNJWkUKICNkZWZpbmUgQktWQVNJWkUJMTYzODQJ LyogbXVzdCBiZSBwb3dlciBvZiAyICovCisjZW5kaWYKICNkZWZpbmUgQktWQU1BU0sJKEJLVkFT SVpFLTEpCiAKIC8qCg== ------=_Part_21885037_470978965.1429487842726--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1552767461.21885039.1429487842728.JavaMail.root>