From owner-cvs-all@FreeBSD.ORG Tue Oct 12 16:54:38 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B39216A4E8; Tue, 12 Oct 2004 16:54:38 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 303EF43D3F; Tue, 12 Oct 2004 16:54:37 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-187-6.dsl.snfc21.pacbell.net [64.171.187.6]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i9CGsU1d019252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 12 Oct 2004 09:54:34 -0700 Message-ID: <416C0C45.6000504@root.org> Date: Tue, 12 Oct 2004 09:54:29 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200410111952.i9BJqVXl083724@repoman.freebsd.org> <200410111608.18915.jhb@FreeBSD.org> <416B0075.1020006@root.org> <200410121037.00260.jhb@FreeBSD.org> In-Reply-To: <200410121037.00260.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2004 16:54:38 -0000 John Baldwin wrote: > On Monday 11 October 2004 05:51 pm, Nate Lawson wrote: > >>John Baldwin wrote: >> >>>On Monday 11 October 2004 03:52 pm, Nate Lawson wrote: >>> >>>>njl 2004-10-11 19:52:31 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c >>>> Log: >>>> Add acpi attachments for ISA sound drivers. This is needed so they'll >>>> probe and attach when ACPI is enabled. >>>> >>>> Submitted by: takawata (sbc fix) >>>> MFC after: 1 day >>> >>>This should only be needed for PnP BIOS cards, not just plain old ISA PnP >>>cards. The es1888.c file is only a driver on Alpha in fact as it >>>basically includes a dummy identify routine to make up for the lack of >>>PnP BIOS on Alphas. >> >>Which of those cards should have the acpi attachment removed? I think >>it should be: >> >>* Removed from es1888.c >>* Added to ess.c:esscontrol >>* Moved from mss.c:snd_mss to snd_pnpmss > > > My gut feeling is that only sbc(4) is actually integrated in motherboards > (note that ACPI and PnP BIOS aren't for PNP ISA cards, but for devices > integrated into the motherboard itself, and not PCI soundcards) but it > doesn't hurt to have the attachment for all PNP-aware ISA sound drivers I > guess. > Ok, that's what I committed. Like you said, it can't hurt. -- Nate