From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu May  6 06:00:14 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C75B21065678
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  6 May 2010 06:00:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id ABEE38FC15
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  6 May 2010 06:00:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4660Cvf017789
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 6 May 2010 06:00:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4660CUr017788;
	Thu, 6 May 2010 06:00:12 GMT (envelope-from gnats)
Resent-Date: Thu, 6 May 2010 06:00:12 GMT
Resent-Message-Id: <201005060600.o4660CUr017788@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Alex Kozlov <spam@rm-rf.kiev.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9E0B4106567A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 May 2010 05:59:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E1AA8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 May 2010 05:59:20 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o465xKBj021041
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 May 2010 05:59:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o465xK6D021040;
	Thu, 6 May 2010 05:59:20 GMT (envelope-from nobody)
Message-Id: <201005060559.o465xK6D021040@www.freebsd.org>
Date: Thu, 6 May 2010 05:59:20 GMT
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/146347: [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2010 06:00:14 -0000


>Number:         146347
>Category:       ports
>Synopsis:       [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 06 06:00:12 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Alex Kozlov
>Release:        RELENG_8
>Organization:
private
>Environment:
>Description:
"Converting DOS text file to UNIX text file: ${f}" don't show file name because ${f} is undefined at this moment.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Mk/bsd.port.mk
@@ -3659,17 +3659,15 @@
 	@${FIND} -E ${WRKSRC} -type f -iregex '${DOS2UNIX_REGEX}' -print0 | \
 			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/$$//'
 .else
+.for f in ${USE_DOS2UNIX}
 	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 .if ${USE_DOS2UNIX:M*/*}
-.for f in ${USE_DOS2UNIX}
 	@${REINPLACE_CMD} -i '' -e 's/$$//' ${WRKSRC}/${f}
-.endfor
 .else
-.for f in ${USE_DOS2UNIX}
 	@${FIND} ${WRKSRC} -type f -name '${f}' -print0 | \
 			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/$$//'
-.endfor
 .endif
+.endfor
 .endif
 .else
 	@${DO_NADA}


>Release-Note:
>Audit-Trail:
>Unformatted: