From owner-freebsd-ports Fri May 17 7:23:16 2002 Delivered-To: freebsd-ports@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id AF5D937B405; Fri, 17 May 2002 07:23:00 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g4HEMKI41030; Fri, 17 May 2002 17:22:20 +0300 (EEST) (envelope-from ru) Date: Fri, 17 May 2002 17:22:20 +0300 From: Ruslan Ermilov To: "Andrey A. Chernov" Cc: walt , freebsd-ports@FreeBSD.ORG, Bill Fenner Subject: Re: Png-1.2.2_1 broken on -CURRENT? Message-ID: <20020517142220.GA37843@sunbay.com> References: <3CE1B2EA.1000900@sbcglobal.net> <20020516235508.GA9554@nagual.pp.ru> <20020517072428.GA75925@sunbay.com> <20020517080609.GA12895@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <20020517080609.GA12895@nagual.pp.ru> User-Agent: Mutt/1.3.99i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 17, 2002 at 12:06:09PM +0400, Andrey A. Chernov wrote: > On Fri, May 17, 2002 at 10:24:28 +0300, Ruslan Ermilov wrote: > > I don't think that calling the 2000/01/14 - 2002/05/12 a "tradition" > > is quite right (these INC*s were added only in bsd.own.mk,v 1.27 and > > are unique to FreeBSD). > >=20 > > For this particular port, it uses the makefile.freebsd specially > > targeted to FreeBSD. Why not just use the bsd.lib.mk for it? >=20 > I'll look at your bsd.lib.mk solution a bit later, thanx. But at this > moment general question still present: if somebody needs exact > INC{OWN,GRP,MODE} to install include files, where he can pick them now? I > don't mean this particular port, but many ports install includes from the > port top level Makefile f.e. >=20 That "many" turns out to be 5 ports, if I'm counting correctly: $ find -s * -name Makefile | xargs egrep -l "INC(OWN|GRP|MODE)" graphics/libflash/files/Makefile graphics/ming/files/Makefile lang/cyclone/Makefile www/mozilla-embedded/Makefile www/mozilla-headers/Makefile First two of these are pure bsd.lib.mk makefiles, and already have some support for older FreeBSD systems that did not have INCS support. They could be fixed as such: INCSDIR=3Dfoo INCDIR=3D ${INCSDIR} # for pre-bsd.incs.mk systems As for the rest of makefiles, they are bsd.port.mk makefiles, and I think they should be fixed to use ${INSTALL_DATA}. That would also autofix them to work in the ${UID} !=3D 0 case. It was my understanding that bsd.port.mk suite should be as much independent of src/ bsd.*.mk stuff as possible, at the end. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE85RIcUkv4P6juNwoRAkFRAJ9uRj4Laik/LLhcndLPLoDHZcC0uQCdH691 LPzrLViSXf4dJIezf5GcNxI= =BbXn -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message