From owner-freebsd-ports@FreeBSD.ORG Sun Aug 28 06:11:22 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D1B1106564A for ; Sun, 28 Aug 2011 06:11:22 +0000 (UTC) (envelope-from 2igosha@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0C2658FC16 for ; Sun, 28 Aug 2011 06:11:21 +0000 (UTC) Received: by bkat8 with SMTP id t8so4649977bka.13 for ; Sat, 27 Aug 2011 23:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=AZV2xvBCNnE8B+WG1nfWDg+r00N4uZJr6dX9ZPm1/Ds=; b=OMedgTOMY8XSlCfitMlBVzxkAcdiGvM/w7YyREjdYMyW1k6N+gErmkfoISgGNqxq68 McfKrXA/fVEZD6ILp/sHDt8uFvNzczF+kVbtT/MUCNEF6IsmF5RqJkRsLAmeULdHQy9n HEPyqPBnKYTBw6CSkVJjXGKh10axVMxeAiuOk= Received: by 10.204.132.212 with SMTP id c20mr1400236bkt.352.1314511880990; Sat, 27 Aug 2011 23:11:20 -0700 (PDT) Received: from [192.168.1.3] ([91.79.151.133]) by mx.google.com with ESMTPS id j17sm867700bks.46.2011.08.27.23.11.19 (version=SSLv3 cipher=OTHER); Sat, 27 Aug 2011 23:11:20 -0700 (PDT) Message-ID: <4E59DC06.3000405@soumenkov.com> Date: Sun, 28 Aug 2011 10:11:18 +0400 From: Igor Soumenkov <2igosha@gmail.com> User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110416 Thunderbird/3.1.9 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <4E58A6AA.4060805@soumenkov.com> <4E58F04F.7030008@cassiba.com> <4E58F3B4.8060706@soumenkov.com> <4E592A74.8020605@soumenkov.com> <4E593F71.1000401@soumenkov.com> <878vqecwnz.fsf@FreeBSD.org> In-Reply-To: <878vqecwnz.fsf@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: How to escalate? ports/159276 - cmake X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2011 06:11:22 -0000 On 28.08.2011 02:33, Raphael Kubo da Costa wrote: > Igor Soumenkov <2igosha@gmail.com> writes: > >> The same effect can be achieved by specifying >> CMAKE_C(XX)_FLAGS_{RELEASE,DEBUG} in command line. >> So, I suggest removing the patch from >> ports/devel/cmake/files/patch-Modules_Compiler_GNU.cmake and patching >> ports/Mk/bsd.cmake.mk instead (attached). After applying this patch >> system C(XX)FLAGS will be propagated for Release and Debug build >> configurations. >> >> [...] >> >> --- ports/Mk/bsd.cmake.mk.original 2011-08-27 21:47:00.000000000 +0400 >> +++ ports/Mk/bsd.cmake.mk 2011-08-27 22:43:46.000000000 +0400 >> @@ -53,7 +53,11 @@ >> CMAKE_ARGS+= -DCMAKE_C_COMPILER:STRING="${CC}" \ >> -DCMAKE_CXX_COMPILER:STRING="${CXX}" \ >> -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ >> + -DCMAKE_C_FLAGS_DEBUG:STRING="${CFLAGS}" \ >> + -DCMAKE_C_FLAGS_RELEASE:STRING="${CFLAGS}" \ >> -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \ >> + -DCMAKE_CXX_FLAGS_DEBUG:STRING="${CXXFLAGS}" \ >> + -DCMAKE_CXX_FLAGS_RELEASE:STRING="${CXXFLAGS}" \ >> -DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \ >> -DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \ >> -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES > At first sight, the patch looks OK to me and solves the problem in a > cleaner way. > > You could try submitting this patch to ports/159276. It might require an > exp-run, but I think it could get in. Submitted the patch.