Date: Sat, 19 Jan 2002 19:36:48 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c Message-ID: <20020119163648.GD10976@nagual.pp.ru> In-Reply-To: <xzp1ygm9vc8.fsf@flood.ping.uio.no> References: <200201190901.g0J91H641020@freefall.freebsd.org> <xzp1ygm9vc8.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 19, 2002 at 17:08:55 +0100, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <ache@FreeBSD.org> writes: > > Log: > > Add PAM_CRED_ERR as valid failure case > > It's not. Only pam_setcred() is allowed to return PAM_CRED_ERR. > > None of your patches to pam_opie, pam_unix or ftpd were reviewed by > anyone with in-depth knowledge of PAM. I'd like you to back them all > out and submit them to markm and myself for review, along with a > *detailed* explanation of what you think is wrong and why you think > your patch is correct. 1) I agree that PAM_CRED_ERR may be not the perfect choice and hear for better altenatives. 2) Excepting that thing, you already see my patches in the tree. I may produce diff, if it is needed. 3) I already post most detailed explanation considering all possible variants. I can resend it to you, if you miss it in the thread. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020119163648.GD10976>