From owner-freebsd-current@FreeBSD.ORG Tue Sep 28 17:26:31 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B34EA16A4CE for ; Tue, 28 Sep 2004 17:26:31 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CF7043D55 for ; Tue, 28 Sep 2004 17:26:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 22719 invoked from network); 28 Sep 2004 17:26:31 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 28 Sep 2004 17:26:30 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8SHQNRN002918; Tue, 28 Sep 2004 13:26:24 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-current@FreeBSD.org Date: Tue, 28 Sep 2004 13:09:26 -0400 User-Agent: KMail/1.6.2 References: <867jqhwhav.fsf@borg.borderworlds.dk> In-Reply-To: <867jqhwhav.fsf@borg.borderworlds.dk> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409281309.26841.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Poul-Henning Kamp cc: njl@FreeBSD.org cc: Christian Laursen Subject: Re: 5.3-BETA5 panic on first boot - floppy related X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2004 17:26:31 -0000 On Sunday 26 September 2004 04:44 am, Christian Laursen wrote: > I upgraded my laptop to 5.3-BETA4 a couple of days ago and have started > to experience it panic ont the first boot if ACPI is enabled. > > Without ACPI it boots fine and after the panic and subsequently typing > 'reset' in the kernel debugger it boots fine with ACPI enabled. > > The dmesg output including a stack trace is here: > http://borderworlds.dk/~xi/vulcan/dmesg.txt > > My kernel configuration is here: > http://borderworlds.dk/~xi/vulcan/VULCAN > > I just tried to boot with the floppy drive attached, but that doesn't > make any difference. There is a bug in the fdc_acpi driver in that it attaches drives via hints even if the controller fails to attach which leads to this panic. A possible fix for RELENG_5 is below: Index: fdc_acpi.c =================================================================== RCS file: /usr/cvs/src/sys/dev/fdc/fdc_acpi.c,v retrieving revision 1.2.2.2 diff -u -r1.2.2.2 fdc_acpi.c --- fdc_acpi.c 18 Sep 2004 04:57:55 -0000 1.2.2.2 +++ fdc_acpi.c 28 Sep 2004 17:07:52 -0000 @@ -130,7 +130,7 @@ bus = device_get_parent(dev); if (ACPI_FAILURE(ACPI_EVALUATE_OBJECT(bus, dev, "_FDE", NULL, &buf))) { error = ENXIO; - goto out; + goto out_hintsprobe; } /* Parse the output of _FDE in various ways. */ @@ -154,7 +154,7 @@ device_printf(dev, "_FDE wrong length: %d\n", obj->Buffer.Length); error = ENXIO; - goto out; + goto out_hintsprobe; } break; case ACPI_TYPE_PACKAGE: @@ -173,17 +173,21 @@ default: device_printf(dev, "invalid _FDE type %d\n", obj->Type); error = ENXIO; - goto out; + goto out_hintsprobe; } /* Add fd child devices as specified. */ error = fdc_acpi_probe_children(bus, dev, fde); -out: - /* If there was a problem, fall back to the hints-based probe. */ +out_hintsprobe: + /* + * If there was a problem with the _FDE drive enumeration, fall + * back to the hints-based probe. + */ if (error) error = fdc_hints_probe(dev); +out: if (buf.Pointer) free(buf.Pointer, M_TEMP); if (error != 0) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org