Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Oct 2014 06:53:49 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r370273 - in head/ports-mgmt/pkg: . files
Message-ID:  <201410070653.s976rnQM094290@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Tue Oct  7 06:53:49 2014
New Revision: 370273
URL: https://svnweb.freebsd.org/changeset/ports/370273
QAT: https://qat.redports.org/buildarchive/r370273/

Log:
  Fix a regression that made some plist errors non fatal
  
  Reported by:	antoine

Added:
  head/ports-mgmt/pkg/files/patch-plist-non-fatal   (contents, props changed)
Modified:
  head/ports-mgmt/pkg/Makefile

Modified: head/ports-mgmt/pkg/Makefile
==============================================================================
--- head/ports-mgmt/pkg/Makefile	Tue Oct  7 06:32:32 2014	(r370272)
+++ head/ports-mgmt/pkg/Makefile	Tue Oct  7 06:53:49 2014	(r370273)
@@ -2,7 +2,7 @@
 
 PORTNAME=	pkg
 DISTVERSION=	1.3.8
-PORTREVISION=	2
+PORTREVISION=	3
 _PKG_VERSION=	${DISTVERSION}
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	\

Added: head/ports-mgmt/pkg/files/patch-plist-non-fatal
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/ports-mgmt/pkg/files/patch-plist-non-fatal	Tue Oct  7 06:53:49 2014	(r370273)
@@ -0,0 +1,31 @@
+diff --git libpkg/pkg_ports.c libpkg/pkg_ports.c
+index 33a29d0..21182b4 100644
+--- libpkg/pkg_ports.c
++++ libpkg/pkg_ports.c
+@@ -1141,7 +1141,7 @@ int
+ ports_parse_plist(struct pkg *pkg, const char *plist, const char *stage)
+ {
+ 	char *line = NULL;
+-	int ret = EPKG_OK;
++	int ret, rc = EPKG_OK;
+ 	struct plist *pplist;
+ 	FILE *plist_f;
+ 	size_t linecap = 0;
+@@ -1162,6 +1162,8 @@ ports_parse_plist(struct pkg *pkg, const char *plist, const char *stage)
+ 		if (line[linelen - 1] == '\n')
+ 			line[linelen - 1] = '\0';
+ 		ret = plist_parse_line(pkg, pplist, line);
++		if (rc == EPKG_OK)
++			rc = ret;
+ 	}
+ 
+ 	free(line);
+@@ -1185,7 +1187,7 @@ ports_parse_plist(struct pkg *pkg, const char *plist, const char *stage)
+ 
+ 	plist_free(pplist);
+ 
+-	return (ret);
++	return (rc);
+ }
+ 
+ int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410070653.s976rnQM094290>