From owner-svn-src-head@freebsd.org Sat Dec 19 19:09:10 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6FB4A4CD4C; Sat, 19 Dec 2015 19:09:10 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0106.outbound.protection.outlook.com [207.46.100.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E9821CD1; Sat, 19 Dec 2015 19:09:09 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from SN1PR05CA0023.namprd05.prod.outlook.com (10.163.68.161) by BLUPR05MB053.namprd05.prod.outlook.com (10.255.210.139) with Microsoft SMTP Server (TLS) id 15.1.337.19; Sat, 19 Dec 2015 19:09:07 +0000 Received: from BL2FFO11OLC014.protection.gbl (2a01:111:f400:7c09::191) by SN1PR05CA0023.outlook.office365.com (2a01:111:e400:5197::33) with Microsoft SMTP Server (TLS) id 15.1.361.13 via Frontend Transport; Sat, 19 Dec 2015 19:09:06 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=freebsd.org; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=freebsd.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning freebsd.org discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BL2FFO11OLC014.mail.protection.outlook.com (10.173.160.144) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Sat, 19 Dec 2015 19:09:06 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sat, 19 Dec 2015 11:00:15 -0800 Received: from [172.29.32.216] (farena-sslvpn-nc.jnpr.net [172.29.32.216]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id tBJJ05D09800; Sat, 19 Dec 2015 11:00:08 -0800 (PST) (envelope-from jtl@freebsd.org) User-Agent: Microsoft-MacOutlook/14.5.9.151119 Date: Sat, 19 Dec 2015 13:53:32 -0500 Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks From: "Jonathan T. Looney" Sender: Jonathan Looney To: Kristof Provost , Randall Stewart CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Thread-Topic: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks References: <201512160056.tBG0ujqA067178@repo.freebsd.org> <3E097253-0E8E-4A50-B1BD-8C9A280E6CD0@sigsegv.be> In-Reply-To: <3E097253-0E8E-4A50-B1BD-8C9A280E6CD0@sigsegv.be> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3533378411_450175" X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC014; 1:wTAdliNwYW/pUZFoyiXFlWSR1XGVFgY5OFUSvZ+h/0k2YGpnN03RHBjJkfy8VH60ugZ6aErooQF7WEbRFAQTMgnkdm9h4uA5eNTlmoO7whI5Nd6LYp9lPIe6/B+Sp0KJPDJSw+1Ssb7E9j0e2cUlqheFs3mqAsh4CNJJN7+82pNuuyDAQhSmaQfMDvD5qj9nLRlU52tBS0h1f7SRnIkgQnaegfvtAAH5WNuVVN66fK4sJ/ekTWAhB4i5emL0yrqffgTDgqCTDwtP+0HP2FJcvDmxGfYOuXT3+jg0xTBPS+UUr1+6B4atjgzVkOcnLkycdl6QGmOzF/97KjX3f9it7y727SR1aGb1y9tcvdM5jlY/PUUCiwy04yRwfMpj/9jy X-Forefront-Antispam-Report: CIP:66.129.239.19; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(479174004)(199003)(377454003)(13624006)(24454002)(189002)(97736004)(83506001)(76176999)(4001350100001)(568964002)(586003)(54356999)(21490400002)(5890100001)(36756003)(19580405001)(19580395003)(81156007)(105596002)(69596002)(84326002)(6806005)(92566002)(5001960100002)(86362001)(1220700001)(50986999)(1096002)(512954002)(15975445007)(4610100001)(189998001)(270700001)(16796002)(2950100001)(87936001)(77096005)(5001770100001)(106466001)(11100500001)(2476003)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR05MB053; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB053; 2:fPO46sHHMnG4SO8UBkM1MxpcXfb6FoK7nTMsuv01CHCxEWr6c5JMUXjhW6VIOpOyFI7wvQZttHBcX5MHref8aCP1glJ6hhRga9QSOkZ0YwGrjVgdnEwwT2b7iyQaOxLagivDrjl+AIP886Mj8QYpEg==; 3:XWpWqc+p+nHwYbsMydU8fGgkRjVQUJRAqCZSy+mT+JfPOb3hU0x7V1Rf3IsB5DLjaIVEYZ0U28n/kDMy+xnz1WsPfLAeje43UrRCblVxjXg67bFgWWZiBOJO2uRU8lemte++V01HAXL+wu0+zGNTAbaU3KoYyqrCF5olS+xkb8tHbYFgkZK0gpXL/0hY9UmZQUN3rFRVl4Xlm4Y/LuoPUen1ckrNopXGbUprgd4xsyM=; 25:b/9cjdlp/A1aHmMlERSnqf/lac30iV/vt2RojFCiKffTm4Z8WDuZawnScNEqIRtTUQJw5q4u/qXI7YQPMhbEFjU7fe6XzJKaLnub2Dm8NtkIgT3O47tlKvsFYnAlK21hoBHk9sB656PS2/+jsgsv0xFER0s994Z4wAEyRJYmdhkD+sM6AeucsIVTLV1iI9uLquGjl3V3MAbKJfycSmp0/zv/Myw2KRjiqLkrGITDdI5f02k5kd9NCIqbfzAXdocMQQwR8g6b+2CjAon1Gy4Zog== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR05MB053; X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB053; 20:y1Pqn3P2QppWk6HtViayucyRQwiJU7qqeYjiYK+/4VPKqIftnxBDv7Bt8J6Uk/NqcMi56QBsqf/LqlblEO/b+IyqvYHuPs/Q3hQooOJDJGFRvh0VRY50YUO6q30jKOPqf0+zk+F7NZlWQaWidc37kQu0CnpYb9NQSuRStIqG+fFXFfXIJqwfbY7ozxX+L77/+ArK2wRFCQ0N7cDS5FtsWYz/ZLQJpFKN+7qxc2ZdDrgFDyOsAtgzH6K4J6O4LF7LD5qbQzl2ypYCuVFS+Vebzy1/RXUqtOLgqtPco9d3Id+pU/P+7oIW7T1y4QlX6bpQOIfncNVa0xk7i9mVt0YwpiL8ytzIMPd77CQp2tfjm0uGyakYzRQASrrMG/GbnqqHqfzXBlcAimG9SCbuL7hnEVSX6WD7UgA+1v4IsTFrMELx69/Weg8icNjNArvV6vinNWaketwXESs9PFSQoTNuFPmFVBPJa1syIiE0MeCUIJEGVXbc5jHvsCpoo5iK85a4; 4:wbgJZSW3XkPGby/fW5jzPUeB91upjrsIbA9NNkeJin9cpdyYzvKEUClAz1I3NkxZkyztXNy4/YRsVqr8FYDANwdEDvAn6bbYYJuQrVulKEHIM1xSB2t8+XxnVKbxMW0IyegrRUbTEslt52u1Z4T244GTDE6vhYUzBbpaWjEZr2dUIUHHZ32cyytgvMI9/QBQbUk6rn6R1TaPaEskQW0S6Mr+vX6kdGugiF3HQWmpHz2Bc5rZZIpiolXMb8pFShaWXe36ZteSwEAboF88y2I0FGceVEsvx4WdhW7vnQ4VWbqS6C7gqKH4TuqM3840+k7slc3XM48PyIzE6PSwW2oVUhvY/sJrNH/Sf3kgJd0Ydvo/O+KeFskZIMS4XVPUeE/f X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046); SRVR:BLUPR05MB053; BCL:0; PCL:0; RULEID:; SRVR:BLUPR05MB053; X-Forefront-PRVS: 07954CC105 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR05MB053; 23:aT/okiUeYNKUQ/Zc9iVqXr12owhJLgVP5/hon+vzFF?= =?us-ascii?Q?S231z5FsQgWKUF3EpCryqGtidudx+r8eKQvlszxd5ZBE9Cg8JgQ/Rac9oRGf?= =?us-ascii?Q?H7jzkAevhoU3J59xIoVRXsRkEw0pW/PseA97Yvdh6Im5f+pLuJK5kMrhvQMl?= =?us-ascii?Q?KdN3AeKviWbxk+tBBQLvLMst3cUSeAGDNRknZpovY6fUCMVLWAsDfCo3AN5G?= =?us-ascii?Q?K2hdmNAK58t8HrJj+PULTyN4ImpSTT6pNynQ2PA2VDs5+ZNOO4hSixRGYLer?= =?us-ascii?Q?2lBdAvRhA4DJdj7zHDTWwxXhpG1GzfVLX7twcJzln1i+657UksBxQ9/i5knA?= =?us-ascii?Q?5l+1cyV4KmAZx0B9lssRyr8sP+lXUxcjPfYIktWzrsYdX0C+ifY5UZOVNpoO?= =?us-ascii?Q?j3A9P+G2btd4AEvrFEDeeIZW29p6uNBmdzqocOcvoRFVvCauTw/rejOtkrjS?= =?us-ascii?Q?cTRHqtcy7XI9s0QDsC9jGVaELwlnoQbdqqTVqbJJ52F88Mgpn1HM1Gv/mPx1?= =?us-ascii?Q?SpTfbDhtNmtnoFirmJf78Q5o1g64x+GxeJnQ9lwpzJHWgGNcLmMH4FzMRNnc?= =?us-ascii?Q?BPq/FNajgOWpbPBVRy3QyQrY8NNUdOib/r/komsLDaXavvUUFCWQS6x/JWYy?= =?us-ascii?Q?yJtAC80Ck+3Pa9ACs072MnFx/x4XzMnIRjPTOnv1e/qcbhlTuD98uT3xP8Yt?= =?us-ascii?Q?opmMIdIP/9AeBvU6H7uf6d0iJZq84ec6Ai8n7Z2jB/ndpc9GcyzvLTVuE+RZ?= =?us-ascii?Q?KkV7vBBi+a7S9dxxtcCCfHiCB1FwLK66rZP29ipiruaDrkOrgd8SY2lDwoV9?= =?us-ascii?Q?GDEW23XyoZGWTJ1jScCER9ACK8g2SHrb1ki1LY2UCcMuPlSIiBoj3zVv12ol?= =?us-ascii?Q?GrwG3sT00y/xkopI9sJ1F59/6/wTA/LYKpIv8p6oPn1tO4VLb1p9vZDyD3Vd?= =?us-ascii?Q?451jrSoKAAeCt15t11g6tZioR6ZDbzJAdCybuPajpMJzsxQbsaUvAQN4BC90?= =?us-ascii?Q?6lZFxBd7rMSs/34k9D3m9rshB1pHvOqt4ZLAFFrZc4tAUY3GUFiWcaCbPISJ?= =?us-ascii?Q?WJnvhWWBZSe1N7WBwUxmqsa4DtK2rhRUrfLP5gwa8eJQh9Z+/vQpkb8W0imI?= =?us-ascii?Q?02veDWlm/ZFRkxJJlUwH91cFfsa1to76K1iaU6jWDqY/Awwk29wJJPpQERgm?= =?us-ascii?Q?P2oxwbD2RrJjuVsWF6rT0w1ccHovRb0bgy?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB053; 5:pQCNFoqz4xjqbUEEBhLdTRJaMrV3Xmrb+s0x+mJlFv3KvQFNYFDrbeSycsynS6mSAKgwX4fULJhft91w3uuj1T6IFt6kwLadECxc8oY+H5Nsieht+vO9xSPwjM3EtQtlisrIxCJx5i4MyVOOPSOXiw==; 24:gGvlmaRWgpWBq0wSD+QFOZWagnDnonA40hc5rM5USjobE2MSceltXGiDYMPJZC8Las2hV976lId60ASNrid3uev8367aVohGD+dNNbDnrnQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2015 19:09:06.3540 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB053 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Dec 2015 19:09:10 -0000 --B_3533378411_450175 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On 12/18/15, 3:54 PM, "owner-src-committers@freebsd.org on behalf of Kristof Provost" wrote: > >> On 16 Dec 2015, at 01:56, Randall Stewart wrote: >> >> Author: rrs >> Date: Wed Dec 16 00:56:45 2015 >> New Revision: 292309 >> URL: https://svnweb.freebsd.org/changeset/base/292309 >> >> Log: >> First cut of the modularization of our TCP stack. Still >> to do is to clean up the timer handling using the async-drain. >> Other optimizations may be coming to go with this. Whats here >> will allow differnet tcp implementations (one included). >> Reviewed by: jtl, hiren, transports >> Sponsored by: Netflix Inc. >> Differential Revision: D4055 > >I suspect this commit broke my machine. I run VIMAGE jails, and see the >following panic as soon as the first jails starts: I think Randall is now (or soon will be) on holiday. Can you try the patch from https://reviews.freebsd.org/D4645 (also attached) and let me know if that fixes the problem? Thanks! Jonathan --B_3533378411_450175 Content-Type: application/octet-stream; name="D4645.diff" Content-Disposition: attachment; filename="D4645.diff" Content-Transfer-Encoding: base64 SW5kZXg6IHN5cy9uZXRpbmV0L3RjcF9zdWJyLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25l dGluZXQvdGNwX3N1YnIuYwkocmV2aXNpb24gMjkyNDY4KQorKysgc3lzL25ldGluZXQvdGNw X3N1YnIuYwkod29ya2luZyBjb3B5KQpAQCAtNTkzLDEwICs1OTMsNiBAQAogCWlmIChoaG9v a19oZWFkX3JlZ2lzdGVyKEhIT09LX1RZUEVfVENQLCBISE9PS19UQ1BfRVNUX09VVCwKIAkg ICAgJlZfdGNwX2hoaFtISE9PS19UQ1BfRVNUX09VVF0sIEhIT09LX05PV0FJVHxISE9PS19I RUFESVNJTlZORVQpICE9IDApCiAJCXByaW50ZigiJXM6IFdBUk5JTkc6IHVuYWJsZSB0byBy ZWdpc3RlciBoZWxwZXIgaG9va1xuIiwgX19mdW5jX18pOwotCS8qIFNldHVwIHRoZSB0Y3Ag ZnVuY3Rpb24gYmxvY2sgbGlzdCAqLwotCVRBSUxRX0lOSVQoJnRfZnVuY3Rpb25zKTsKLQly d19pbml0X2ZsYWdzKCZ0Y3BfZnVuY3Rpb25fbG9jaywgInRjcF9mdW5jX2xvY2siICwgMCk7 Ci0JcmVnaXN0ZXJfdGNwX2Z1bmN0aW9ucygmdGNwX2RlZl9mdW5jYmxrLCBNX1dBSVRPSyk7 CiAJaGFzaHNpemUgPSBUQ0JIQVNIU0laRTsKIAlUVU5BQkxFX0lOVF9GRVRDSCh0Y2JoYXNo X3R1bmVhYmxlLCAmaGFzaHNpemUpOwogCWlmIChoYXNoc2l6ZSA9PSAwKSB7CkBAIC02NzUs NiArNjcxLDEwIEBACiAJdGNwX3JleG1pdF9zbG9wID0gVENQVFZfQ1BVX1ZBUjsKIAl0Y3Bf Zmlud2FpdDJfdGltZW91dCA9IFRDUFRWX0ZJTldBSVQyX1RJTUVPVVQ7CiAJdGNwX3RjYmhh c2hzaXplID0gaGFzaHNpemU7CisJLyogU2V0dXAgdGhlIHRjcCBmdW5jdGlvbiBibG9jayBs aXN0ICovCisJVEFJTFFfSU5JVCgmdF9mdW5jdGlvbnMpOworCXJ3X2luaXRfZmxhZ3MoJnRj cF9mdW5jdGlvbl9sb2NrLCAidGNwX2Z1bmNfbG9jayIgLCAwKTsKKwlyZWdpc3Rlcl90Y3Bf ZnVuY3Rpb25zKCZ0Y3BfZGVmX2Z1bmNibGssIE1fV0FJVE9LKTsKIAogCWlmICh0Y3Bfc29y ZWNlaXZlX3N0cmVhbSkgewogI2lmZGVmIElORVQK --B_3533378411_450175--