Date: Fri, 7 Sep 2001 07:00:46 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Alfred Perlstein <bright@mu.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio stdio.c Message-ID: <20010907070046.A95860@nagual.pp.ru> In-Reply-To: <20010906215518.X81307@elvis.mu.org> References: <200109070213.f872DCa19917@freefall.freebsd.org> <20010906212527.W81307@elvis.mu.org> <20010907063714.B95517@nagual.pp.ru> <20010906215518.X81307@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 06, 2001 at 21:55:18 -0500, Alfred Perlstein wrote: > * Andrey A. Chernov <ache@nagual.pp.ru> [010906 21:37] wrote: > > On Thu, Sep 06, 2001 at 21:25:27 -0500, Alfred Perlstein wrote: > > > change you did broke things. One way to fix this would be to record > > > the failed lseek returning EISPIPE and noting that the backing > > > object is not seekable, from then on you could avoid the unnescesary > > > syscalls. > > > > I plan to do exact the same thing you describe (i.e. remove __SAPP when > > ESPIPE happens) + add error checking for __SOPT (i.e. regular) files only. > > I'm not sure that's completely safe, a user defined stdio stream > may switch the underlying file, it we cache information we may > break the ability to do that. __SAPP is set only in one place (for fdopen()'ed files) and never for user-defined streams. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010907070046.A95860>