From owner-freebsd-ports Fri Aug 16 10:40: 8 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7609137B400 for ; Fri, 16 Aug 2002 10:40:04 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0ECD343E42 for ; Fri, 16 Aug 2002 10:40:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7GHe3JU037908 for ; Fri, 16 Aug 2002 10:40:03 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7GHe3MF037907; Fri, 16 Aug 2002 10:40:03 -0700 (PDT) Date: Fri, 16 Aug 2002 10:40:03 -0700 (PDT) Message-Id: <200208161740.g7GHe3MF037907@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Christian Weisgerber Subject: Re: ports/41710: [port] lame update (fix CFLAGS) Reply-To: Christian Weisgerber Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/41710; it has been noted by GNATS. From: Christian Weisgerber To: lioux@FreeBSD.org Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: ports/41710: [port] lame update (fix CFLAGS) Date: Fri, 16 Aug 2002 18:44:25 +0200 (CEST) In article <200208161520.g7GFK3Cq017168@freefall.freebsd.org> you write: > What about making patch optional? I mean, > if the user adds WITH_OPTIMIZED_CFLAGS, this patch is not applied. > Otherwise, it is applied per default. What's the gain? The whole point of making a port honor CFLAGS is that users can set them at their convenience. If somebody wants to build lame with super-duper optimization flags, they can just do so with $ CFLAGS="-O1000 -mfoo -fbar" make build (Personally, I'd go for something like CC=ccc CFLAGS=-fast.) > Check audio/liba52/Makefile for an example. Truly pointless, IMO. -- Christian "naddy" Weisgerber naddy@mips.inka.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message