From owner-cvs-all@FreeBSD.ORG Thu Jul 8 00:56:31 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3775D16A4CE for ; Thu, 8 Jul 2004 00:56:31 +0000 (GMT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id DF3A743D3F for ; Thu, 8 Jul 2004 00:56:30 +0000 (GMT) (envelope-from nate@root.org) Received: (qmail 94872 invoked by uid 1000); 8 Jul 2004 00:56:32 -0000 Date: Wed, 7 Jul 2004 17:56:32 -0700 (PDT) From: Nate Lawson To: "M. Warner Losh" In-Reply-To: <40EC9698.4050201@root.org> Message-ID: <20040707175502.M94870@root.org> References: <20040707223539.6114C16A5B4@hub.freebsd.org> <40EC7A5A.3010303@root.org> <20040707.183145.79073073.imp@bsdimp.com> <40EC9698.4050201@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: [src] cvs commit: src/sys/dev/fdc fdc.c fdc_isa.c fdc_pccard.c fdcvar.h src/sys/modules/fdc Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2004 00:56:31 -0000 On Wed, 7 Jul 2004, Nate Lawson wrote: > M. Warner Losh wrote: > > I went the route of 'exposing' the softc, because that's how newbus > > works: it manages the softc, and in order to manage the softc you have > > to expose its size. I treid to express that in the reviews, but I > > guess that got lost in the shuffle. Bruce doesn't like it, but we do > > it all over the place and the world hasn't come to the end. Anyway, > > after the set of mail that was sent out, I thought that I was supposed > > to commit the simple split, then you were going to specialize things > > for acpi. That's why I went ahead and committed this. phk's recent > > changes to fdc reminded me to merge this stuff.... > > What about instead exposing the size through a extern const int and used > that to set the softc size in the device initialization? The internals > of the softc aren't really needed. > > My code uses a softc size of zero and has a function in fdc.c that is > called by bus attachments that allocates it and does a > device_set_softc(). This mostly works. Actually, I forgot to ask -- are you ok with me committing my code which hides the softc and uses device_set_softc() privately within fdc.c to manage it? We'll still need fdcvar.h to hold function definitions. -Nate