From owner-svn-src-head@FreeBSD.ORG Sun Mar 25 20:25:43 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50A7B106566C; Sun, 25 Mar 2012 20:25:43 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id B2B008FC3B; Sun, 25 Mar 2012 20:25:42 +0000 (UTC) Received: by qcsg15 with SMTP id g15so3435513qcs.13 for ; Sun, 25 Mar 2012 13:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=QtRt1GQ0yyRQu9qkbVxQTA/bvZRJgzr3C6ZMLaY/bs0=; b=xtX5kTERO7uclmkPdSDLwJ9dyxunf9HA8GFVkzII+DQUCJWgPhhsUe0AHrb1OkLDk3 zTLUdySzSy13VwFqo3Ms6AjaUgKKNE2QcRBI5carB5sTBQBZ95ySQuRWFQ7LufWwO5Hv lbCewnCUtJqapmigZM+9P/uiUjs42xm/LWzAEnHG5OYxWM132vIPH44skDDxKBtuWO8s OhnP+TcOLvAzMBarQRWUluztUt9Ax51rRShe2ZVimiVu8Zdk0WjTBk0+WiS7IbzrLkfR eZIH+HphPpkfnV/UVf50IAX6YLsAQ0tuwP1Qw8ohch611lm9MeoizLYg5GqBXtWBlFqp pmTg== Received: by 10.224.101.72 with SMTP id b8mr24919354qao.31.1332707136287; Sun, 25 Mar 2012 13:25:36 -0700 (PDT) Received: from kan.dyndns.org (c-24-63-226-98.hsd1.ma.comcast.net. [24.63.226.98]) by mx.google.com with ESMTPS id 1sm26223314qac.3.2012.03.25.13.25.35 (version=SSLv3 cipher=OTHER); Sun, 25 Mar 2012 13:25:35 -0700 (PDT) Date: Sun, 25 Mar 2012 16:25:28 -0400 From: Alexander Kabaev To: Marius Strobl Message-ID: <20120325162528.7f73300c@kan.dyndns.org> In-Reply-To: <201203212055.q2LKtMYR093218@svn.freebsd.org> References: <201203212055.q2LKtMYR093218@svn.freebsd.org> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/M=KMPHEp7tOmJHtkHiLMNpO"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233288 - in head/sys: boot/common libkern sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2012 20:25:43 -0000 --Sig_/M=KMPHEp7tOmJHtkHiLMNpO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Mar 2012 20:55:22 +0000 (UTC) Marius Strobl wrote: > Modified: head/sys/sys/libkern.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/libkern.h Wed Mar 21 20:53:47 2012 > (r233287) +++ head/sys/sys/libkern.h Wed Mar 21 20:55:21 > 2012 (r233288) @@ -121,7 +121,7 @@ size_t strspn(const > char *, const char char *strstr(const char *, const char *); > int strvalid(const char *, size_t); > =20 > -extern uint32_t crc32_tab[]; > +extern const uint32_t const crc32_tab[]; > =20 > static __inline uint32_t > crc32_raw(const void *buf, size_t size, uint32_t crc) Hi, g++ produces "error: duplicate 'const'" on this changed line. Leaving the question as to why this file is ever being compiled by C++ on the conscience of of VirtualBox authors, I would suggest partially backing out this commit and getting easier on 'const' for C++'s sake.=20 --=20 Alexander Kabaev --Sig_/M=KMPHEp7tOmJHtkHiLMNpO Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iD8DBQFPb389Q6z1jMm+XZYRAu9aAKCT5xRcekTe8Z3bC7wGtoeKmWhAqQCffA87 UFMXWot/IhgdQTuQCoe+DoE= =Fj62 -----END PGP SIGNATURE----- --Sig_/M=KMPHEp7tOmJHtkHiLMNpO--