From owner-freebsd-hackers@FreeBSD.ORG  Sun Jul 24 22:22:24 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 5A48D1065675; Sun, 24 Jul 2011 22:22:24 +0000 (UTC)
Date: Sun, 24 Jul 2011 22:22:24 +0000
From: Alexander Best <arundel@freebsd.org>
To: Edward Tomasz Napiera?a <trasz@freebsd.org>
Message-ID: <20110724222224.GA64487@freebsd.org>
References: <0CEA161B-6767-4379-B923-585B3D4EA74E@freebsd.org>
	<86hb6e1bau.fsf@gmail.com>
	<589EB85A-1902-4643-A1FD-3C98445127DB@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <589EB85A-1902-4643-A1FD-3C98445127DB@freebsd.org>
Cc: Test Rat <ttsestt@gmail.com>, freebsd-hackers@freebsd.org
Subject: Re: Autosizing column widths in ps(1).
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jul 2011 22:22:24 -0000

On Sun Jul 24 11, Edward Tomasz Napiera?a wrote:
> Wiadomo?? napisana przez Test Rat w dniu 22 lip 2011, o godz. 19:21:
> > Edward Tomasz Napiera?a <trasz@freebsd.org> writes:
> > 
> >> Patch below changes ps(1) to automatically size column widths according to their
> >> contents.  From the user point of view, it prevents breaking layout with too wide values
> >> and in most cases makes output narrower.  From the developer point of view, it removes
> >> the need to specify widths.  Testing is welcome - the patch shouldn't change ps(1)
> >> behaviour except slightly changing the widths, but the code changes are pretty large
> >> and it's quite possible I've missed something.
> > 
> > STAT column seems to be right-aligned when it was previously left-aligned.
> > This makes sorting it harder, e.g.
> > 
> >  $ ps ax | (IFS=; read h; echo $h; sort -k3) | less
> 
> Good catch, thanks!  Updated patch, which also fixes two issues affecting TTY column,
> is at http://people.freebsd.org/~trasz/ps-9.diff.

working great here. have you experienced any performance issues, due to ps
having to iterate through all columns before constructing the output in
comparison to the previous design?

cheers.
alex

P.S.: one utility which would also benefit from auto column sizing is top, for
sure! ;)

> 
> --
> If you cut off my head, what would I say?  Me and my head, or me and my body?
>