From owner-svn-src-all@freebsd.org  Wed Mar 21 16:46:14 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC98AF5377D;
 Wed, 21 Mar 2018 16:46:14 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16])
 by mx1.freebsd.org (Postfix) with ESMTP id 7CF987A0C3;
 Wed, 21 Mar 2018 16:46:14 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from [IPv6:2001:630:212:2a8:c475:595a:854e:1122] (unknown
 [IPv6:2001:630:212:2a8:c475:595a:854e:1122])
 by fry.fubar.geek.nz (Postfix) with ESMTPSA id 9B0644EB9F;
 Wed, 21 Mar 2018 16:45:35 +0000 (UTC)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: svn commit: r331306 - head/sys/dev/usb/controller
From: Andrew Turner <andrew@fubar.geek.nz>
In-Reply-To: <b8627a61-adde-a9b4-8cd1-af9435b9ea92@selasky.org>
Date: Wed, 21 Mar 2018 16:45:34 +0000
Cc: Kyle Evans <kevans@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <898DF1A6-F1D2-474C-92B5-12F65DC71A40@fubar.geek.nz>
References: <201803211517.w2LFHsHf007714@repo.freebsd.org>
 <CACNAnaHCf8paMB3RP1SSnP45xPTSKEcJp-qKyKievLE0E_svWA@mail.gmail.com>
 <b8627a61-adde-a9b4-8cd1-af9435b9ea92@selasky.org>
To: Hans Petter Selasky <hps@selasky.org>
X-Mailer: Apple Mail (2.3445.5.20)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2018 16:46:15 -0000



> On 21 Mar 2018, at 15:37, Hans Petter Selasky <hps@selasky.org> wrote:
>=20
> On 03/21/18 16:24, Kyle Evans wrote:
>>> +       {
>>> +               .ep_end =3D 7,
>>> +               .ep_fifosz_shift =3D 9,
>>> +               .ep_fifosz_reg =3D MUSB2_VAL_FIFOSZ_512 | =
MUSB2_MASK_FIFODB,
>>> +       },
>> I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for
>> this case drop to 9? frx =3D 10 in the temp < 8 case in the removals =
of
>> the following hunks. Mostly curious because the others seemed to stay
>> the same.
>=20
> Hi Andrew,
>=20
> It might be an idea to keep the fifosz_shift at 10, else high-speed =
BULK traffic won't be double buffered, and this might affect =
performance.

Should the endpoint 1 size also be fixed? The register has it at 4k, but =
it wasn=E2=80=99t an 8k buffer.

Andrew