From owner-freebsd-embedded@FreeBSD.ORG Fri Dec 30 00:23:19 2011 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BB631065672; Fri, 30 Dec 2011 00:23:19 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea]) by mx1.freebsd.org (Postfix) with ESMTP id CD83C8FC12; Fri, 30 Dec 2011 00:23:18 +0000 (UTC) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 0E16511215B; Fri, 30 Dec 2011 00:23:18 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=iso-8859-1 From: Stefan Bethke In-Reply-To: <7A8E7854-4696-44B9-B0BE-3D6640BA0A49@lassitu.de> Date: Fri, 30 Dec 2011 01:23:17 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7EAD98F7-FDB6-404B-82FE-8D5BC081BD9B@lassitu.de> References: <0F6CC18F-6973-42A2-AC03-F01BF59458AE@lassitu.de> <1100F70E-9DA9-4163-AC9A-423ECE5AA9A3@lassitu.de> <18CABB46-9B9A-41CB-8742-6723C5FF4D67@lassitu.de> <2CBD8651-E132-49DC-A082-37A8F5C626EA@bsdimp.com> <267FB3D6-830E-4A2F-8C1C-A96873EDCD31@lassitu.de> <12538AED-175C-4B1E-BF05-6FD05D14CE70@lassitu.de> <2135AD2B-76D4-4B3D-A009-8F3BEC836051@lassitu.de> <2BB71545-7DE9-493D-92FE-AD4CEDCBF2D1@lassitu.de> <7A8E7854-4696-44B9-B0BE-3D6640BA0A49@lassitu.de> To: Adrian Chadd X-Mailer: Apple Mail (2.1251.1) Cc: "freebsd-embedded@freebsd.org" Subject: Re: Updated switch/glue patch? X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2011 00:23:19 -0000 Am 29.12.2011 um 17:56 schrieb Stefan Bethke: > Am 29.12.2011 um 11:18 schrieb Stefan Bethke: >=20 >> http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work = (branch work/ath) >> http://www.lassitu.de/freebsd/etherswitch-adrian.patch (patch against = Adrians gitorious repo as of now) >> http://www.lassitu.de/freebsd/etherswitch.tbz (all files) >=20 > With this version, I get no WITNESS warnings, nor panics from the = callout. > The retries for I2C select and PHY register access always succeed = (100k+ > test accesses in a tight loop). All the retries are probably bogus. I've switched back to the original = version of iicbb.c, and I'm not getting a single retry on either select = or PHY register access. I'll look into why my improved code is working worse than the original, = but for the time being, we should stick to the original code. The = recovery options in rtl8366rb.c don't really hurt and can stay for the = moment. Stefan --=20 Stefan Bethke Fon +49 151 14070811