From owner-freebsd-current@freebsd.org Fri Dec 4 09:28:17 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D58DA401C6 for ; Fri, 4 Dec 2015 09:28:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7D190111E for ; Fri, 4 Dec 2015 09:28:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7BE00A401C5; Fri, 4 Dec 2015 09:28:17 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61AE9A401C3 for ; Fri, 4 Dec 2015 09:28:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05208111C; Fri, 4 Dec 2015 09:28:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tB49SBpG044874 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 4 Dec 2015 11:28:11 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tB49SBpG044874 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tB49SAsr044873; Fri, 4 Dec 2015 11:28:10 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 4 Dec 2015 11:28:10 +0200 From: Konstantin Belousov To: Daniel Eischen Cc: current@freebsd.org Subject: Re: librt symbol versioning breakage (was Re: Build failure, undefined reference to __mq_oshandle) Message-ID: <20151204092810.GM2405@kib.kiev.ua> References: <20151129102903.GD3448@kib.kiev.ua> <20151130145518.GK3448@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 09:28:17 -0000 On Thu, Dec 03, 2015 at 10:34:10PM -0500, Daniel Eischen wrote: > On Mon, 30 Nov 2015, Konstantin Belousov wrote: > > > On Sun, Nov 29, 2015 at 12:27:40PM -0500, Daniel Eischen wrote: > >> On Sun, 29 Nov 2015, Konstantin Belousov wrote: > >> > >>> On Sun, Nov 29, 2015 at 01:23:04AM -0500, Daniel Eischen wrote: > >>>> > >>>> So I found out that sometime in the last year or so, symbol versioning > >>>> for librt was broken and leaking symbols that shouldn't have been > >>>> leaked. I've just committed a fix for this. > >>>> > >>>> Do a 'readelf -sw /usr/lib/librt.so.1 | grep GLOBAL | grep -v UND' > >>>> and see the non FBSD_foo symbols that shouldn't be there. > >>> > >>> I did the following on the librt from the HEAD of about month ago: > >>> > >>> pooma% ls -l netboot/sandy/usr/lib/librt.so.1 > >>> -r--r--r-- 1 root wheel 23704 Oct 24 23:35 netboot/sandy/usr/lib/librt.so.1 > >>> > >>> pooma% readelf -sw netboot/sandy/usr/lib/librt.so.1 | grep GLOBAL | grep -v UND | grep -v FBSDpriv | grep FBSD > >>> 97: 0000000000000000 0 OBJECT GLOBAL DEFAULT ABS FBSD_1.0 > >>> > >>> But I think that your commit is the good change. > >> > >> > >> Can you check librt.so.1 in your buildworld temporary build > >> environment? > >> > >> $ readelf -sW /usr/obj/usr/FreeBSD/svn/src/tmp/usr/lib/librt.so.1 \ > >> grep -v UND | grep GLOBAL > >> > >> There has to be a reason that tests/sys/mqueue/mqtest[3-4].c build > >> without error when they reference __mq_oshandle. That symbol is > >> not exported from librt. > >> > >> Hmm, looks like libc and libthr are also the same (leaky) in the > >> temporary build environment (TBE). So something broke when building > >> the TBE libraries. > >> > >> For r277320 on my system Jan 19, 2015, the TBE libraries must have > >> been built correctly because mqtests[3-4] failed with unresolved > >> references to __mq_oshandle. > > > > In fact, my command was wrong. I see that there are indeed a lot of symbols > > exported which are not versioned (this is where my command was wrong, the > > grep FBSD part), even for the installed librt. > > Arrgh, this bug also seems to have slipped into 10-stable. > > $ uname -a > FreeBSD 10.1-RELEASE-p9 FreeBSD 10.1-RELEASE-p9 #0: Tue Apr 7 > 01:09:46 UTC 2015 > root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 > $ readelf -sW /usr/lib/librt.so.1 | grep -v UND | grep GLOBAL \ > | grep -v FBSD > 71: 0000000000003ac0 432 FUNC GLOBAL DEFAULT 12 __sigev_alloc > ... > $ readelf -sW /usr/lib/librt.so.1 | grep -v UND | grep GLOBAL \ > | grep -v FBSD | wc -l > 22 Yes, I did my check on stable/10 FWIW.