From owner-svn-src-projects@freebsd.org Thu Nov 16 16:56:41 2017 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1DF9DE2E26 for ; Thu, 16 Nov 2017 16:56:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 738C618C8; Thu, 16 Nov 2017 16:56:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 897F94D0C; Thu, 16 Nov 2017 16:56:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 760F322B1; Thu, 16 Nov 2017 16:56:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id CXs2MFcJ05gg; Thu, 16 Nov 2017 16:56:36 +0000 (UTC) Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 50C7122AC To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-projects@freebsd.org References: <201711161513.vAGFDThx060235@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Thu, 16 Nov 2017 08:56:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201711161513.vAGFDThx060235@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 16:56:41 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3 Content-Type: multipart/mixed; boundary="dJq4P30mqlfkK6aGe015IRAkmqUViwOwb"; protected-headers="v1" From: Bryan Drewery To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-projects@freebsd.org Message-ID: Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 References: <201711161513.vAGFDThx060235@repo.freebsd.org> In-Reply-To: <201711161513.vAGFDThx060235@repo.freebsd.org> --dJq4P30mqlfkK6aGe015IRAkmqUViwOwb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/16/2017 7:13 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Nov 16 15:13:28 2017 > New Revision: 325894 > URL: https://svnweb.freebsd.org/changeset/base/325894 >=20 > Log: > Update list of hardcoded OFED build order dependencies for > the buildworld target. > =20 > Sponsored by: Mellanox Technologies >=20 > Modified: > projects/bsd_rdma_4_9/Makefile.inc1 >=20 > Modified: projects/bsd_rdma_4_9/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- projects/bsd_rdma_4_9/Makefile.inc1 Thu Nov 16 14:37:18 2017 (r3258= 93) > +++ projects/bsd_rdma_4_9/Makefile.inc1 Thu Nov 16 15:13:28 2017 (r3258= 94) > @@ -2410,16 +2410,33 @@ _lib_libradius=3D lib/libradius > .endif > =20 > .if ${MK_OFED} !=3D "no" > -_ofed_lib=3D contrib/ofed/usr.lib > -_prebuild_libs+=3D contrib/ofed/usr.lib/libosmcomp > -_prebuild_libs+=3D contrib/ofed/usr.lib/libopensm > -_prebuild_libs+=3D contrib/ofed/usr.lib/libibcommon > -_prebuild_libs+=3D contrib/ofed/usr.lib/libibverbs > -_prebuild_libs+=3D contrib/ofed/usr.lib/libibumad > +_ofed_lib=3D \ > +contrib/ofed/include \ > +contrib/ofed/libcxgb4 \ > +contrib/ofed/libibcm \ > +contrib/ofed/libibmad \ > +contrib/ofed/libibnetdisc \ > +contrib/ofed/libibumad \ > +contrib/ofed/libibverbs \ > +contrib/ofed/libmlx4 \ > +contrib/ofed/libmlx5 \ > +contrib/ofed/librdmacm \ > +contrib/ofed/opensm/complib \ > +contrib/ofed/opensm/libopensm \ > +contrib/ofed/opensm/libvendor > =20 > -contrib/ofed/usr.lib/libopensm__L: lib/libthr__L > -contrib/ofed/usr.lib/libosmcomp__L: lib/libthr__L > -contrib/ofed/usr.lib/libibumad__L: contrib/ofed/usr.lib/libibcommon__L= > +contrib/ofed/libcxgb4__L: contrib/ofed/libibverbs__L lib/libthr__L con= trib/ofed/include__L > +contrib/ofed/libibcm__L: contrib/ofed/libibverbs__L contrib/ofed/inclu= de__L > +contrib/ofed/libibmad__L: contrib/ofed/libibumad__L contrib/ofed/inclu= de__L > +contrib/ofed/libibnetdisc__L: contrib/ofed/opensm/complib__L contrib/o= fed/libibmad__L contrib/ofed/libibumad__L contrib/ofed/include__L > +contrib/ofed/libibumad__L: contrib/ofed/include__L > +contrib/ofed/libibverbs__L: contrib/ofed/include__L > +contrib/ofed/libmlx4__L: contrib/ofed/libibverbs__L lib/libthr__L cont= rib/ofed/include__L > +contrib/ofed/libmlx5__L: contrib/ofed/libibverbs__L lib/libthr__L cont= rib/ofed/include__L > +contrib/ofed/librdmacm__L: contrib/ofed/libibverbs__L contrib/ofed/inc= lude__L > +contrib/ofed/opensm/complib__L: lib/libthr__L contrib/ofed/include__L > +contrib/ofed/opensm/libopensm__L: lib/libthr__L contrib/ofed/include__= L > +contrib/ofed/opensm/libvendor__L: contrib/ofed/libibumad__L lib/libthr= __L contrib/ofed/include__L > .endif > =20 > .if ${MK_CASPER} !=3D "no" >=20 This isn't right, you don't need to include any 'include' directories in here as 'make includes' is ran before 'make libraries'. You don't need libthr either as it is in prebuild_libs which is built before all of this. I suspect the actual change needed is far smaller than this. --=20 Regards, Bryan Drewery --dJq4P30mqlfkK6aGe015IRAkmqUViwOwb-- --dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaDcM2AAoJEDXXcbtuRpfPi78H/12XZ98CiMwnWr+OmLK4IUot KSgM/IDA3BJyHm4l2zYDYVn9IepddjArEyHy+l1hchfj/V5dTqA7RKGM5XitAPIh jUkbn9GdRvZnW4ar5hYDcEideIQXgyNx9H4Eq/ZcvE+XTLXir8wbnZ9oVV8xYmEK hqtyWeqcDVEp/qxe8gM9Sr+UX66MAGsdRX5gHfN4NVr235h7R1Xi4VJo+LPkctyl tnaX3fnQpJCpxJGh9HoR6Yc+/DlfZU8ZE3AYB0hky37QVAdC9J2rnXev8c0hQGP6 Ewv0dTzVcWryMc8p8LSQbdHkgARVLpOPksBEwVIYu2TLmHJjfqjpc4WbcBZf76U= =jnWK -----END PGP SIGNATURE----- --dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3--