From owner-svn-src-all@freebsd.org Tue Mar 7 09:12:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2C1FD001C5; Tue, 7 Mar 2017 09:12:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E0281D4C; Tue, 7 Mar 2017 09:12:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22f.google.com with SMTP id w189so72392126pfb.0; Tue, 07 Mar 2017 01:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=m6Vei1lawii4jr0tx16yCLjw+zjuWvi6KdEqeAI6PaI=; b=o7opE0P3ffq42qwgUHvHE0lyeUbOIQPZeU2Sa1aLi/Dk2HtdVCWsDId+FzTSBrGeLZ ZIwGNEgRI9+JUk7lDJoUxKekccspuZpJP8l3N5xqlNf95g5Rsz8FUc0r0SakHENBfDZq f2n7/0WWoWwe2eg/gIKESbjSfRgnEBe2s2K3+rFkMcAbqmyVUE0XqPoZIgp4ZTHxjdB4 pg3no51Rkh5y8+hjE/BbIbkGj4VXkufkZ/T794zkA8La++v1FvcjpFges1MgM55l0wXB cQaKkmeuPN7ws6jMhAKL4dCkdvkiWidd8L39eaOPhCPrWYupAXIk69BSXqyjw8Y87LVZ qBTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=m6Vei1lawii4jr0tx16yCLjw+zjuWvi6KdEqeAI6PaI=; b=nZ49RYr4Q0cmeNh7RW3xnJtLPmKrNnQDDE59XDa3nQZBKewph4zD3bBrFyzWzhKxOO 81kDTm3tr748ZSUL70jebl++3l+rmY8zP4Qa/AtzqbH7zu79GaaFomT3nSyIbyrW1IZ9 X6cABJxMEUoqD81OvI8JQN2IyQWx+ykaaSNj6rgIGtdEv/FkVuxlsoXuo8EYK65YqXt3 VGVeEPGTZ40FwodX8BmoidA1/fiaiFfH4zVC1NOegRpOy89BsugtE9ILDj/9GozuNb2h VQQV5dwHSehR4gbv70aSPBTmkO0MOsEzUchs7EkBTeCdpMate20u408g+CyD7bI6YgD/ mCRA== X-Gm-Message-State: AMke39m9uXDdaJni5FdWhFfKQz/3AavLyjY8ijBTIS+ftLnV+bjddc8dqLtWdY+9O8ay7Q== X-Received: by 10.99.225.5 with SMTP id z5mr25805756pgh.145.1488877952843; Tue, 07 Mar 2017 01:12:32 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a5sm14268558pfh.124.2017.03.07.01.12.31 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Mar 2017 01:12:32 -0800 (PST) Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201703070904.v2794RLY093614@pdx.rh.CN85.dnsmgr.net> Date: Tue, 7 Mar 2017 01:12:31 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201703070904.v2794RLY093614@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 09:12:33 -0000 --Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 7, 2017, at 01:04, Rodney W. Grimes = wrote: >=20 >>>=20 >>> On Mar 6, 2017, at 21:50, Rodney W. Grimes = wrote: >>>=20 >>>>> On Mar 6, 2017, at 21:10, Rodney W. Grimes = wrote: >>>>>=20 >>>>> Author: rgrimes >>>>> Date: Tue Mar 7 05:10:38 2017 >>>>> New Revision: 314833 >>>>> URL: https://svnweb.freebsd.org/changeset/base/314833 >>> ... >>>=20 >>>>>=20 >>>>> -SYMLINKS+=3D ${LIBDIR}/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>>>> +SYMLINKS+=3D ../../../tests/lib/libxo/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>>>=20 >>>> This change breaks setting TESTSBASE !=3D /usr/tests . Please = fix (my employer depends on this being functional). >>>> Thanks, >>>=20 >>> I am just going to revert this until the issue with SYMLINKS vs = RSYMLINKS and >>> probably a much better fix in bsd.*.mk can be implemented. I can = live with >>> one last nasty wart of an absolute link in DESTDIR until then. The = important >>> functional ones are gone now. >>>=20 >>> To fix this without changing SYMLINKS would involve adding a local = install: >>> target which would be more mess than having the one absolute link. >>=20 >> The proposed enhancement for bsd.links.mk for RSYMLINKS can be found = here: https://reviews.freebsd.org/D9919 . >=20 > I dont think that is what bapt/bdrewery had in mind, I think they = wanted to > replicate the SYMLINK=3D as RSYMLINK=3D and use that when needed. >=20 > I have thought about this and we do not ever want absolute links in = the tree, > so much simpler fix is to just convert SYMLINKS to call = INSTALL_RSYMLINKS > instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be = fixed, > and as long as no one uses INSTALL_SYMLINKS. SYMLINKS has been around since r245752. I personally don=E2=80=99t know = if it=E2=80=99s wise to remove functionality that=E2=80=99s been =E2=80=9C= in production=E2=80=9D for 4+ years. Making the target intelligently use one command over the other might = seem ok, but it could have unintended consequences. I think it=E2=80=99s = best to have another well-documented variable that uses INSTALL_RSYMLINK = vs INSTALL_SYMLINK. Also, in the CR, please note that the SYMLINKS piece doesn=E2=80=99t = prefix source targets with ${DESTDIR}, whereas the LINKS (and soon to be = RSYMLINKS portion) will need it in order to compute the right paths and = execute the right behavior. Otherwise, you=E2=80=99re going to be = breaking someone=E2=80=99s use for SYMLINKS for no good reason. Thanks, -Ngie --Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvnl/AAoJEPWDqSZpMIYV9FwP/RMj3HAeTCsRRR2RtR4qQf7Y Kx/SLxc9DMPwCBMja2H8U00SEItld294N+Ze3V0Kxp1amFEhMuhgiDRdwRhLGTMp 8VkN8EIBqBAAfr3i6/0bmyHYxV4HhDRTRsSg4dX3UfxiTXo+cJDSBiCiZp+kr8B6 9kK9wNeKucR8Lu3TsH8vwwLYEq/+wVwYeLPbRjIxbMrYpbWUw/nm+PB9S2gfqDxH uwr9+a4zCWL4GWuc6AuKnw0N8Ixc2YqdreiozETVqcvv6Xv7LElyYVNqD8zsjbO/ cIRpnHjlQykZ75xEl7m4GvTJvH4C81SRmxQLQPjwyNPrJ63T6z1HeOU7uiBtud+d opADMG0phZtT95p+PKZe7HHRQMDit0BAA0C4QZzJW+7zmCHgAMddF6ld7bfujaO5 8vybSn/1KlBpdlNDL9IljDTkwrvy++jp/4FWGgkrBlwn5Z7nLZq3EZMKU/UyGmXe N5QM7uVsFHIeniYDcwtSswAsVdyWQNyXlsuGE0TKN4xCiiR1xIZi081qIACyuwhU mfV5gLLaNjN/J8yVGOWNdXGTqkg5UWWUoRd2o+MLgHxGfQnojY10bJ+Jdf05CI5Z XZcxs6RU54tWiBC4338ImoxrntOFtW5c1C98pocS0PV4ddxMBjhJ9cKMiwp/01sR q5MO6RCRe8/K06RoWZL7 =fZs5 -----END PGP SIGNATURE----- --Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277--