From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Nov 28 04:40:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D56F2112 for ; Thu, 28 Nov 2013 04:40:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 963E212CB for ; Thu, 28 Nov 2013 04:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAS4e14E080540 for ; Thu, 28 Nov 2013 04:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAS4e1ge080527; Thu, 28 Nov 2013 04:40:01 GMT (envelope-from gnats) Resent-Date: Thu, 28 Nov 2013 04:40:01 GMT Resent-Message-Id: <201311280440.rAS4e1ge080527@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3B1FCE7; Thu, 28 Nov 2013 04:36:47 +0000 (UTC) Received: from smtpout1.timeweb.ru (smtpout1.timeweb.ru [92.53.117.15]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E80D412B8; Thu, 28 Nov 2013 04:36:46 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1VltLH-0000Fa-Cc; Thu, 28 Nov 2013 08:36:43 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 08E131C3A; Thu, 28 Nov 2013 08:36:43 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id F2215429; Thu, 28 Nov 2013 08:36:42 +0400 (MSK) Message-Id: <20131128043642.F2215429@hades.panopticon> Date: Thu, 28 Nov 2013 08:36:42 +0400 (MSK) From: Dmitry Marakasov To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/184346: [PATCH] ports-mgmt/porttools: incorrect svn detection Cc: mat@FreeBSD.org, joemann@beefree.free.de, tota@FreeBSD.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 04:40:01 -0000 >Number: 184346 >Category: ports >Synopsis: [PATCH] ports-mgmt/porttools: incorrect svn detection >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Nov 28 04:40:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 10.0-BETA3 amd64 >Organization: >Environment: System: FreeBSD hades.panopticon 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r258666: Wed Nov 27 03:06:10 MSK >Description: Porttools check for .svn subdirectory in the port's dir to check whether SVN diff method should be used. With newer svn versions (1.7, 1.8) this check will fail, as there's only single .svn directory in the working directory root but not in the subdirectories. Probably `svn info` output should be checked instead. With this bug, `port submit` produces patches with simple diff which contain RCS id changes ($FreeBSD$) - with these, patch usually does not apply making life harder for committers, so this should be fixed pretty much as soon as possible. It'd also be useful to add --ignore-properties to svn diff here. Port maintainer (joemann@beefree.free.de) is cc'd. Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN) >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: