Date: Thu, 28 Nov 2013 08:36:42 +0400 (MSK) From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: FreeBSD-gnats-submit@freebsd.org Cc: mat@FreeBSD.org, joemann@beefree.free.de, tota@FreeBSD.org Subject: ports/184346: [PATCH] ports-mgmt/porttools: incorrect svn detection Message-ID: <20131128043642.F2215429@hades.panopticon> Resent-Message-ID: <201311280440.rAS4e1ge080527@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 184346 >Category: ports >Synopsis: [PATCH] ports-mgmt/porttools: incorrect svn detection >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Nov 28 04:40:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 10.0-BETA3 amd64 >Organization: >Environment: System: FreeBSD hades.panopticon 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r258666: Wed Nov 27 03:06:10 MSK >Description: Porttools check for .svn subdirectory in the port's dir to check whether SVN diff method should be used. With newer svn versions (1.7, 1.8) this check will fail, as there's only single .svn directory in the working directory root but not in the subdirectories. Probably `svn info` output should be checked instead. With this bug, `port submit` produces patches with simple diff which contain RCS id changes ($FreeBSD$) - with these, patch usually does not apply making life harder for committers, so this should be fixed pretty much as soon as possible. It'd also be useful to add --ignore-properties to svn diff here. Port maintainer (joemann@beefree.free.de) is cc'd. Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN) >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131128043642.F2215429>