From owner-freebsd-ports@FreeBSD.ORG Mon Jan 22 18:02:09 2007 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5F6B616A401; Mon, 22 Jan 2007 18:02:09 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from sccrmhc11.comcast.net (sccrmhc11.comcast.net [63.240.77.81]) by mx1.freebsd.org (Postfix) with ESMTP id E74C713C43E; Mon, 22 Jan 2007 18:02:08 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from icarus.home.lan (c-71-198-0-135.hsd1.ca.comcast.net[71.198.0.135]) by comcast.net (sccrmhc11) with ESMTP id <2007012218020801100neq5ae>; Mon, 22 Jan 2007 18:02:08 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id DEBB51FA037; Mon, 22 Jan 2007 10:02:07 -0800 (PST) Date: Mon, 22 Jan 2007 10:02:07 -0800 From: Jeremy Chadwick To: Anders Nordby , ale@FreeBSD.org, ports@FreeBSD.org Message-ID: <20070122180207.GA63696@icarus.home.lan> Mail-Followup-To: Anders Nordby , ale@FreeBSD.org, ports@FreeBSD.org References: <20070122153932.GA45748@fupp.net> <20070122164211.GA62774@icarus.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070122164211.GA62774@icarus.home.lan> X-PGP-Key: http://jdc.parodius.com/pubkey.asc User-Agent: Mutt/1.5.13 (2006-08-11) Cc: Subject: Re: Upgrade mysql50-server/client to 5.0.33 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 18:02:09 -0000 On Mon, Jan 22, 2007 at 08:42:11AM -0800, Jeremy Chadwick wrote: > On Mon, Jan 22, 2007 at 04:39:32PM +0100, Anders Nordby wrote: > > Hi, > > > > The following patch updates the port to 5.0.33. Time to update it? > > I have to recommend against this update. Stay with 5.0.27 for now, > as the following bug affects InnoDB on 5.0.32 and 5.0.33: > > http://bugs.mysql.com/bug.php?id=25653 > http://bugs.mysql.com/bug.php?id=25596 Anders and I have discussed this a bit. 5.0.27 has clustering- related problems, while 5.0.33 has this InnoDB problem. What a mess. :-) The InnoDB problem (and fix) is documented in MySQL Bug 25596 (comment dated 16 Jan 19:04 by Heikki Tuuri). In innobase/dict/dict0dict.c: Fix: replace strchr(" \v\f\t\r\n", c) with (strchr(" \v\f\t\r\n", c) && c != '\0') The official MySQL 5.0 server repository does not show signs of this fix being applied yet. Look for the line labelled "#define ib_isspace(c)" here: http://mysql.bkbits.net:8080/mysql-5.0/innobase/dict/dict0dict.c?PAGE=anno&REV=%2b The implementation on 5.1 is very different, thus the bug doesn't exist there. Since there's a fix available, I'm cool with the port being upgraded from 5.0.27 to 5.0.33 assuming we add a patch for this fix to files/ until the MySQL guys address the problem in the official source. -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |