From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 15 13:20:02 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 952A01065670 for ; Tue, 15 May 2012 13:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4C7778FC0C for ; Tue, 15 May 2012 13:20:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4FDK2uQ049631 for ; Tue, 15 May 2012 13:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4FDK2LY049630; Tue, 15 May 2012 13:20:02 GMT (envelope-from gnats) Resent-Date: Tue, 15 May 2012 13:20:02 GMT Resent-Message-Id: <201205151320.q4FDK2LY049630@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bryan Drewery Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 180811065674 for ; Tue, 15 May 2012 13:19:32 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id BB7848FC2B for ; Tue, 15 May 2012 13:19:31 +0000 (UTC) Received: (qmail 25839 invoked from network); 15 May 2012 08:19:28 -0500 Received: from unknown (HELO test8.xzibition.com) (10.10.0.34) by sweb.xzibition.com with SMTP; 15 May 2012 08:19:28 -0500 Received: by test8.xzibition.com (sSMTP sendmail emulation); Tue, 15 May 2012 08:19:05 -0500 Message-Id: <20120515131932.180811065674@hub.freebsd.org> Date: Tue, 15 May 2012 08:19:05 -0500 From: "Bryan Drewery" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: eadler@FreeBSD.org, beat@FreeBSD.org Subject: ports/167923: [PATCH] ports-mgmt/portlint: Make NO_CHECKSUM error more strict. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bryan Drewery List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2012 13:20:02 -0000 >Number: 167923 >Category: ports >Synopsis: [PATCH] ports-mgmt/portlint: Make NO_CHECKSUM error more strict. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue May 15 13:20:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Bryan Drewery >Release: FreeBSD 8.3-RELEASE i386 >Organization: >Environment: >Description: Update error for NO_CHECKSUM to be more strict. Use the wording from bsd.port.mk instead of 'discouraged' which implies it is ok in some cases. >How-To-Repeat: >Fix: --- patch-portlint-NO_CHECKSUM.txt begins here --- diff --git Makefile Makefile index 320a3e8..649e30b 100644 --- Makefile +++ Makefile @@ -8,7 +8,7 @@ # PORTNAME= portlint -PORTVERSION= 2.13.9 +PORTVERSION= 2.13.10 CATEGORIES= ports-mgmt MASTER_SITES= # none DISTFILES= # none diff --git src/portlint.pl src/portlint.pl index 1eee0c3..12ff3ce 100644 --- src/portlint.pl +++ src/portlint.pl @@ -1606,8 +1606,8 @@ sub checkmakefile { print "OK: checking NO_CHECKSUM.\n" if ($verbose); if ($whole =~ /\nNO_CHECKSUM/) { my $lineno = &linenumber($`); - &perror("FATAL", $file, $lineno, "use of NO_CHECKSUM discouraged. ". - "it is intended to be a user variable."); + &perror("FATAL", $file, $lineno, "NO_CHECKSUM is a user ". + "variable and is not to be set in the a port's Makefile."); } # --- patch-portlint-NO_CHECKSUM.txt ends here --- >Release-Note: >Audit-Trail: >Unformatted: