From owner-freebsd-stable@FreeBSD.ORG Thu Nov 3 20:08:49 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62343106566B for ; Thu, 3 Nov 2011 20:08:49 +0000 (UTC) (envelope-from ml@os2.kiev.ua) Received: from s1.sdv.com.ua (s1.sdv.com.ua [77.120.97.61]) by mx1.freebsd.org (Postfix) with ESMTP id D65358FC17 for ; Thu, 3 Nov 2011 20:08:48 +0000 (UTC) Received: from 80-105-243-80.cust.centrio.cz ([80.243.105.80] helo=[192.168.101.100]) by s1.sdv.com.ua with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76 (FreeBSD)) (envelope-from ) id 1RM3af-000DMJ-AA; Thu, 03 Nov 2011 22:08:47 +0200 Message-ID: <4EB2F4C6.30508@os2.kiev.ua> Date: Thu, 03 Nov 2011 21:08:38 +0100 From: Alex Samorukov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Thomas Eberhardt References: <4EB1BCAD.7080206@zzattack.org> <20111102233807.GA67112@icarus.home.lan> <4EB1D6F9.3060008@zzattack.org> <20111103000124.GA67550@icarus.home.lan> <4EB1DD51.4080808@zzattack.org> <20111103002352.GA67904@icarus.home.lan> <4EB2538D.3090108@zzattack.org> <4EB2CB75.6070003@os2.kiev.ua> <4EB2E2D7.2050809@os2.kiev.ua> <5AA1B2B7-EC88-44E0-9537-A91E2AFDFFFE@googlemail.com> In-Reply-To: <5AA1B2B7-EC88-44E0-9537-A91E2AFDFFFE@googlemail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SA-Score: -1.0 Cc: FreeBSD Stable Mailing List Subject: Re: smartctl / mpt on 9.0-RC1 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2011 20:08:49 -0000 Thank you, it is really caused by MFC r225950 and smartctl way to detect sense length. I decided not to add ifdefs, but change the logic. I fixed this in SVN [1], patch in the unified diff format could be downladed at [2]. Please test this, and if it works fine - i will submit PR to the port. [1] https://sourceforge.net/apps/trac/smartmontools/changeset?old_path=%2Ftrunk%2Fsmartmontools%2Fos_freebsd.cpp&old=3468&new_path=%2Ftrunk%2Fsmartmontools%2Fos_freebsd.cpp&new=3467 [2] https://sourceforge.net/apps/trac/smartmontools/changeset?format=diff&new=3467&old=3468&new_path=trunk%2Fsmartmontools%2Fos_freebsd.cpp&old_path=trunk%2Fsmartmontools%2Fos_freebsd.cpp :On 11/03/2011 08:05 PM, Thomas Eberhardt wrote: > Hi. I got the same problem. After some debugging I came up with the > following patch: > > --- os_freebsd.cpp.orig 2011-10-06 18:43:44.000000000 +0200 > +++ os_freebsd.cpp 2011-10-23 11:19:31.492599837 +0200 > @@ -1044,8 +1044,13 @@ > } > > if (iop->sensep) { > +#if CAM_VERSION< 0x16 > memcpy(iop->sensep,&(ccb->csio.sense_data),sizeof(struct scsi_sense_data)); > iop->resp_sense_len = sizeof(struct scsi_sense_data); > +#else > + memcpy(iop->sensep,&(ccb->csio.sense_data),sizeof(struct scsi_sense_data_fixed)); > + iop->resp_sense_len = sizeof(struct scsi_sense_data_fixed); > +#endif > } > > iop->scsi_status = ccb->csio.scsi_status; > > > > On 03.11.2011, at 19:52, Alex Samorukov wrote: > >