Date: Tue, 28 Mar 2017 15:26:12 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Michael Gmelin <grembo@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files Message-ID: <20170328152612.GC20879@FreeBSD.org> In-Reply-To: <20170328165708.3feecd6a@bsd64.grem.de> References: <201703272235.v2RMZKfx024323@repo.freebsd.org> <20170328142701.GA20879@FreeBSD.org> <20170328165708.3feecd6a@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 28, 2017 at 04:57:08PM +0200, Michael Gmelin wrote:
> On Tue, 28 Mar 2017 14:27:01 +0000
> Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > ...
> > Bogus formatting (one extra tab after knobs), would you please fix it?
>
> These are in to align to
>
> TEST_TEST_TARGET=<tab>test, otherwise it would look like this:
>
> TEST_USES= compiler:c++11-lib
> TEST_TEST_TARGET=test
I'm not even sure why wrapping test-framework stuff in options-framework,
was it because of TEST_USES (since TEST_DEPENDS was not really what you
wanted)?
> (replaced tabs by spaces for email)
>
> Would this actually be preferred?
Options-support (helper) knobs are indeed longer than usual and might
require special care (esp. when mixed with shorter knobs) to get pretty
alignment, and that's OK since they are usually grouped together after
OPTIONS_DEFINE (or OPTIONS_DEFAULT -- since it also is overly long).
That said, there is no reason to double-tab standard width knobs that
preceed OPTIONS_DEFINE just to align them with what goes below it.
OPTIONS_DEFINE is a nice dividing line (esp. since it often gets quite
long as well).
So, group longer option helper knobs and align within them, but don't
aling the entire Makefile with them.
> > Any reason why option helper target (post-extract-TEST-on) was not
> > used here?
>
> Simply unaware it existed, so this would change to:
>
> post-extract-TEST-on:
> ${INSTALL_DATA} ${FILESDIR}/Makefile.in ${WRKSRC}/Makefile
> ${INSTALL_DATA} ${FILESDIR}/test-minimal.cpp ...
Right; now don't take my word for it, rehash PHB and `Mk/bsd.options.mk'
and test changes thoroughly. :-)
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170328152612.GC20879>