Date: Mon, 23 Oct 2000 15:40:57 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Tor.Egge@fast.no Cc: null@pozo.com, current@FreeBSD.org, valentin@valcho.net Subject: RE: sys/i386/i386/machdep.c:cpu_idle() changes causes this Was: Message-ID: <XFMail.001023154057.jhb@FreeBSD.org> In-Reply-To: <200010222232.AAA72847@midten.fast.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22-Oct-00 Tor.Egge@fast.no wrote: >> >> On 20-Oct-00 Valentin Chopov wrote: >> > I found that if I remove #ifndef SMP /#endif in: >> >> Errr, this doesn't really make sense, and if anything is probably >> hiding the problem. Also, this change will potentially increase >> interrupt latency even further on SMP machines. > > Interrupts are disabled if Giant is busy in vm_page_zero_idle, thus > the idle proc calls mi_switch with interrupts disabled and the process > being scheduled starts running with interrupts disabled. > > I suggest removing the asm statement from vm_page_zero_idle as a first > stage in rewriting vm_page_zero_idle. Ahhhh.. Thanks for the tip. I didn't know that vm_page_zero_idle was this evil. Yuck. In fact, vm_page_zero_idle() is no longer called with interrupts disabled, so all the interrupt foolishness can go away. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001023154057.jhb>