From owner-cvs-all Sat Oct 6 13:52:47 2001 Delivered-To: cvs-all@freebsd.org Received: from kayak.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by hub.freebsd.org (Postfix) with ESMTP id 5FD1A37B406; Sat, 6 Oct 2001 13:52:22 -0700 (PDT) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by kayak.xcllnt.net (8.11.4/8.11.4) with ESMTP id f96KqLI68769; Sat, 6 Oct 2001 13:52:21 -0700 (PDT) (envelope-from marcel@kayak.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.11.6/8.11.5) id f96KqKI06984; Sat, 6 Oct 2001 13:52:20 -0700 (PDT) (envelope-from marcel) Date: Sat, 6 Oct 2001 13:52:20 -0700 From: Marcel Moolenaar To: Warner Losh Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ia64/include cpufunc.h Message-ID: <20011006135220.A1606@athlon.pn.xcllnt.net> References: <20011006121654.B68233@kayak.xcllnt.net> <200110060931.f969ViC77564@freefall.freebsd.org> <20011006224619.X1107-100000@delplex.bde.org> <200110061947.f96JlU747798@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200110061947.f96JlU747798@harmony.village.org> User-Agent: Mutt/1.3.21i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Oct 06, 2001 at 01:47:30PM -0600, Warner Losh wrote: > In message <20011006121654.B68233@kayak.xcllnt.net> Marcel Moolenaar writes: > : I thought so. What is the right place, then. It seems that bus_memio.h > : is a good match, but that file is empty for all ports and thus is > : making me nervous. The other logical place is bus.h. On alpha the > : functions are there, but that's mostly because of the implementation. > > bus_memio.h means "I'll use memory operations for this driver" and if > bus_pio.h is also included, that means "I'll use I/o operations for > this driver." this allows bus_space stuff to be highly optimized for > those drivers that cannot possibly talk to memory or pio hardware, > because such hardware doesn't exist. Ah, it basicly serves the same purpose as something like: #define BUS_MEMIO 1 #include > Don't put anything else in them. And complain to Justin Gibbs about > the API, not me, if you don't like it because he invented it :-) It doesn't really matter what I like. It's just that I'm covering new areas in the kernel (read: I'm way over my head here :-) and the purpose is not trivially clear. A note in the header files would help for example. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message