From owner-freebsd-hackers@FreeBSD.ORG  Wed Feb  4 19:19:10 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E0ADA106567A
	for <freebsd-hackers@FreeBSD.org>; Wed,  4 Feb 2009 19:19:10 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 02EE28FC14
	for <freebsd-hackers@FreeBSD.org>; Wed,  4 Feb 2009 19:19:09 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id VAA10207
	for <freebsd-hackers@FreeBSD.org>; Wed, 04 Feb 2009 21:19:07 +0200 (EET)
	(envelope-from avg@icyb.net.ua)
Message-ID: <4989EA2A.6050601@icyb.net.ua>
Date: Wed, 04 Feb 2009 21:19:06 +0200
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.19 (X11/20090110)
MIME-Version: 1.0
To: freebsd-hackers@FreeBSD.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: 
Subject: NO_WERROR vs kernel builds
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2009 19:19:11 -0000


It seems that kernel builds ignore NO_WERROR.
Is this on purpose or by accident?

I think that this happens because of the following lines in
sys/conf/kern.pre.mk:

.if ${CC} != "icc"
CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
CFLAGS+= --param inline-unit-growth=100
CFLAGS+= --param large-function-growth=1000
.if ${MACHINE_ARCH} == "amd64" || ${MACHINE} == "i386" || \
    ${MACHINE_ARCH} == "ia64" || ${MACHINE_ARCH} == "powerpc" || \
    ${MACHINE_ARCH} == "sparc64"
WERROR?= -Werror
.endif
.endif

I had to specify WERROR= on make's command line to catch a certain kind
of warnings in bulk instead of one by one. This was not obvious.

-- 
Andriy Gapon