From owner-freebsd-geom@FreeBSD.ORG Wed Sep 15 05:29:48 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9753116A4CE for ; Wed, 15 Sep 2004 05:29:48 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2E1043D2F for ; Wed, 15 Sep 2004 05:29:47 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i8F5Tagr008860; Wed, 15 Sep 2004 07:29:41 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Allan Fields From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 14 Sep 2004 23:17:33 EDT." <20040915031733.GA17432@afields.ca> Date: Wed, 15 Sep 2004 07:29:36 +0200 Message-ID: <8859.1095226176@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: DOT cc: freebsd-geom@freebsd.org Subject: Re: Can't reattach gbde slice [testing] X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2004 05:29:48 -0000 In message <20040915031733.GA17432@afields.ca>, Allan Fields writes: >On Sat, Sep 11, 2004 at 07:59:07PM +0200, Poul-Henning Kamp wrote: >> can you try the two fixes I just committed to -current ? > >Yes, seems to solve problems attaching in this test case. >I've tried to break things again: so far seems fine, but >haven't done anything exhaustive. > >Is it necessary after patching to rebuild number_of_keys=1 volumes >that haven't had key sector problems yet? I would do it to be on the safe side if I were you. If it is very cumbersome, it would be possible to tell from the four keysector locations and the disk-size if there is any danger: basically if any of the "unused" locations address modulus 2^32 are inside the size of the disk, then the volume is at risk. >Will patches be included in upcoming 5.3-release? Otherwise >notification in errata would help, just in case people setup such >a device. yes. >Those with existing such volumes should now dump the filesystem >and apply patches since they might otherwise loose data w/ existing >gbde device and an unpatched kernel. yes. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.