From owner-svn-ports-head@freebsd.org Tue Apr 23 16:27:27 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF5D6159EC33; Tue, 23 Apr 2019 16:27:27 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id 5B9FB805CB; Tue, 23 Apr 2019 16:27:27 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.15.2/8.15.2) with ESMTP id x3NGRPdm058003; Tue, 23 Apr 2019 09:27:25 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.15.2/8.15.2/Submit) id x3NGRPPI058002; Tue, 23 Apr 2019 09:27:25 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Tue, 23 Apr 2019 09:27:25 -0700 From: Greg Lewis To: Mathieu Arnold Cc: Greg Lewis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499685 - head/java/openjdk8 Message-ID: <20190423162725.GA57876@misty.eyesbeyond.com> References: <201904222052.x3MKqqVH050067@repo.freebsd.org> <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 5B9FB805CB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.935,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 16:27:28 -0000 On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote: > On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote: > > Author: glewis > > Date: Mon Apr 22 20:52:52 2019 > > New Revision: 499685 > > URL: https://svnweb.freebsd.org/changeset/ports/499685 > > > > Log: > > Always depend on fontconfig > > > > PR: 203862 > > Submitted by: Dominik Lisiak > > You need to bump PORTREVISION when you change the runtime dependencies. I didn't bump it since this is a build fix. I.e., we fail the configure step without the dependency. If that still requires a PORTREVISION bump then I think the porters handbook could use with some clarification on the topic. > > Modified: > > head/java/openjdk8/Makefile > > > > Modified: head/java/openjdk8/Makefile > > ============================================================================== > > --- head/java/openjdk8/Makefile Mon Apr 22 20:42:39 2019 (r499684) > > +++ head/java/openjdk8/Makefile Mon Apr 22 20:52:52 2019 (r499685) > > @@ -18,7 +18,8 @@ BUILD_DEPENDS= zip:archivers/zip \ > > autoconf>0:devel/autoconf \ > > -/include/cups/cups.h:print/cups \ > > bash:shells/bash > > -LIB_DEPENDS= libfreetype.so:print/freetype2 \ > > +LIB_DEPENDS= libfontconfig.so:x11-fonts/fontconfig \ > > + libfreetype.so:print/freetype2 \ > > libinotify.so:devel/libinotify > > RUN_DEPENDS= javavm:java/javavmwrapper \ > > dejavu>0:x11-fonts/dejavu > > @@ -105,8 +106,7 @@ X11_CONFIGURE_OFF= --disable-headful > > X11_CONFIGURE_ON= --with-giflib=system \ > > --x-includes=-/include \ > > --x-libraries=-/lib > > -X11_LIB_DEPENDS= libgif.so:graphics/giflib \ > > - libfontconfig.so:x11-fonts/fontconfig > > +X11_LIB_DEPENDS= libgif.so:graphics/giflib > > X11_MAKE_ENV_OFF= BUILD_HEADLESS_ONLY=1 \ > > MAKEFLAGS=X_CFLAGS="-I-/include" > > X11_MAKE_ENV_ON= MAKEFLAGS=""