Date: Sun, 1 Jul 2012 21:23:42 +0100 (BST) From: Chris Rees <crees@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/169585: [PATCH] net-mgmt/send Use OSVERSION instead of checking for file Message-ID: <20120701202342.6B4A5A3EA@pegasus.bayofrum.net> Resent-Message-ID: <201207012030.q61KUBHA076810@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169585 >Category: ports >Synopsis: [PATCH] net-mgmt/send Use OSVERSION instead of checking for file >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jul 01 20:30:11 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 9.0-RELEASE amd64 >Organization: >Environment: System: FreeBSD pegasus.bayofrum.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sun Apr 29 12:29:02 BST 2012 root@pegasus.bayofrum.net:/usr/obj/usr/src/sys/PEGASUS amd64 >Description: Send should not check for the existence of a file; it is slower than an OSVERSION check and also fails to register as a DUD on pointyhat-west http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/e.8-exp.20120218044950.pointyhat-west/send-0.3.log As a nice side effect, make index will be a few nanoseconds faster. >How-To-Repeat: >Fix: --- patch.txt begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/net-mgmt/send/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile --- Makefile 2 Jan 2011 17:56:14 -0000 1.5 +++ Makefile 1 Jul 2012 20:21:08 -0000 @@ -21,7 +21,9 @@ PKGMESSAGE= ${WRKDIR}/pkg-message PORTDOCS= README UserGuide.pdf -.if !exists(/usr/include/netinet6/send.h) +.include <bsd.port.pre.mk> + +.if ${OSVERSION} < 900042 IGNORE= is supported only on 9.0 and later .endif @@ -42,4 +44,4 @@ .endif @${CAT} ${PKGMESSAGE} -.include <bsd.port.mk> +.include <bsd.port.post.mk> --- patch.txt ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120701202342.6B4A5A3EA>