From owner-svn-src-all@FreeBSD.ORG Sun Mar 27 22:32:45 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D34E106566B; Sun, 27 Mar 2011 22:32:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B31518FC16; Sun, 27 Mar 2011 22:32:44 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63] (may be forged)) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p2RMTS0A076694; Sun, 27 Mar 2011 16:29:28 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <4D8F7257.50207@FreeBSD.org> Date: Sun, 27 Mar 2011 16:29:28 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201103271657.p2RGvs2m063692@svn.freebsd.org> <4D8F7257.50207@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1082) Cc: Josh Paetzel , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, kib@FreeBSD.org Subject: Re: svn commit: r220059 - head/usr.sbin/pc-sysinstall/backend X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2011 22:32:45 -0000 On Mar 27, 2011, at 11:22 AM, Doug Barton wrote: > On 03/27/2011 09:57, Josh Paetzel wrote: >> Replace "$?" =3D "0" with $? -eq 0 in tests >=20 > Excellent! Most of the time I've found that moving the command up to the if makes = the code clearer too. At jobs I've had in the past when I've written = code similar to what we have here, it almost always got flagged... Warner