Date: Sun, 29 Mar 2015 14:29:07 +0200 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r382595 - head/net/hostapd Message-ID: <5517F013.6090403@marino.st> In-Reply-To: <FC0C9C741284BFF1D1E45566@atuin.in.mat.cc> References: <201503291215.t2TCFfpV085298@svn.freebsd.org> <FC0C9C741284BFF1D1E45566@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/29/2015 15:20, Mathieu Arnold wrote:
> +--On 29 mars 2015 12:15:41 +0000 John Marino <marino@FreeBSD.org> wrote:
> | +OPTIONS_DEFINE= PORTS_SSL
> | +
> | +PORTS_SSL_DESC= Build with OpenSSL from ports (instead of base system)
> | +
> | +.include <bsd.port.options.mk>
> | +
> | +.if ${PORT_OPTIONS:MPORTS_SSL}
> | +.if !defined(WITH_OPENSSL_PORT)
> | +IGNORE= the PORTS_SSL option not allowed when WITH_OPENSSL_PORT is not
> | set +.endif
> | +CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> | +.else
> | +.if defined(WITH_OPENSSL_PORT)
> | +IGNORE= the PORTS_SSL option is required when WITH_OPENSSL_PORT is set
> | +.endif
> | +.endif
>
> That seems way overly complicated, why not just do:
>
> .if defined(WITH_OPENSSL_PORT)
> CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> .endif
I assume the maintainer wants to preserve the possibility to not include
openssl capability at all... (neither port nor base)
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5517F013.6090403>