From owner-freebsd-standards@FreeBSD.ORG Thu Apr 17 07:00:10 2008 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59DE0106566C for ; Thu, 17 Apr 2008 07:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3F91C8FC13 for ; Thu, 17 Apr 2008 07:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3H70AFP083336 for ; Thu, 17 Apr 2008 07:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3H70A1Z083335; Thu, 17 Apr 2008 07:00:10 GMT (envelope-from gnats) Date: Thu, 17 Apr 2008 07:00:10 GMT Message-Id: <200804170700.m3H70A1Z083335@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: David Xu Cc: Subject: Re: standards/122051: Add posix_spawn(3) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: David Xu List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2008 07:00:10 -0000 The following reply was made to PR standards/122051; it has been noted by GNATS. From: David Xu To: Ed Schouten Cc: bug-followup@freebsd.org Subject: Re: standards/122051: Add posix_spawn(3) Date: Thu, 17 Apr 2008 14:59:12 +0800 Ed Schouten wrote: > * Ed Schouten wrote: >> The OpenSolaris code seems to use errno. > > It's still early in the morning here. OpenSolaris seems to return the > error numbers. I'll update the patch this evening. Thanks! > Also, the manual pages should remove word "shall" or replace it with something, because we either implement the features or not. Also, in the following code : + case FAE_CLOSE: + /* Perform a close() */ + if (_close(fae->fae_fildes) != 0) + _exit(127); + break; I think the it should only check errno EBADF, other error codes are not failure cases, the file handle is always freed. Regards, David Xu