From owner-freebsd-arch@FreeBSD.ORG Wed Mar 8 09:22:32 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E933816A420 for ; Wed, 8 Mar 2006 09:22:32 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au [211.29.132.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E60143D48 for ; Wed, 8 Mar 2006 09:22:32 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail06.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k289M8rO006171 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 8 Mar 2006 20:22:09 +1100 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.4/8.13.4) with ESMTP id k289M8i4001261; Wed, 8 Mar 2006 20:22:08 +1100 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.4/8.13.4/Submit) id k289M80Q001260; Wed, 8 Mar 2006 20:22:08 +1100 (EST) (envelope-from peter) Date: Wed, 8 Mar 2006 20:22:07 +1100 From: Peter Jeremy To: "M. Warner Losh" Message-ID: <20060308092207.GB679@turion.vk2pj.dyndns.org> References: <20060307.233728.42821161.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060307.233728.42821161.imp@bsdimp.com> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: arch@freebsd.org Subject: Re: Fw: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 09:22:33 -0000 On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote: >This is the first commit of many to do what the comment says. ... > Log: > Remove leading __ from __(inline|const|signed|volatile). They are > obsolete. This should reduce diffs to NetBSD as well. K&R function definitions are even more obsolete but still used throughout the kernel. IMHO, potential diff-reduction to NetBSD seems a fairly flimsy reason for a significant amount of churn. Also, any diff reduction with NetBSD is probably outweighed by the diff increase with other FreeBSD branches. Maybe this should be treated like whitespace cleanup - something to do if you're going to be doing something non-trivial in the source file. (There are probably other cleanups in the same category). -- Peter Jeremy